-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for pandoc 3.1.7 #403
Conversation
Tests updated in view of pandoc commit f7035d080c617cda3804a7d0932da8283a5c681c: > LaTeX writer link/target improvements. > > + Use `\phantomsection` and `\label` instead of `\hypertarget`. > + Use `\hyperref` for LaTeX internal links, `\hyperlink` for > beamer (since `\hyperref` doesn't seem to work). > > Closes #9022.
0266607
to
7017864
Compare
Unsure why nix build is failing, though |
In all likelihood, you just need to bump hackage.nix in flake.lock (e.g. This Pandoc update, however, is a problem, see #402. We need to remove |
Ah, missed that. That will require better understanding of these codepaths than I possess, hope I at least gave something of value. |
The update required non-trivial changes to the output, so I've opted to do those manually. In any case, thanks for the PR, sorry I didn't merge it. |
On Sat, Sep 23, 2023 at 10:23:51AM -0700, Nikolay Yakimov wrote:
The update required non-trivial changes to the output, so I've opted to do those manually. In any case, thanks for the PR, sorry I didn't merge it.
No problem -- in view of #402, my PR wasn't very useful.
Though, it does raise the question -- it took quite a bit of effort to write,
and it's something I'd rather not duplicate next time there's a breaking change.
Is there interest in eg teaching the testsuite to generate new golden tests when
pandoc's changes don't break stuff for us? That way, this PR could've just been
a single script invocation in the release engineering.
|
Golden tests in Golden tests in |
Tests updated in view of jgm/pandoc@f7035d0