Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for pandoc 3.1.7 #403

Closed
wants to merge 1 commit into from
Closed

Conversation

hseg
Copy link
Contributor

@hseg hseg commented Sep 3, 2023

Tests updated in view of jgm/pandoc@f7035d0

@hseg hseg marked this pull request as ready for review September 3, 2023 09:04
Tests updated in view of pandoc commit
f7035d080c617cda3804a7d0932da8283a5c681c:
> LaTeX writer link/target improvements.
>
> + Use `\phantomsection` and `\label` instead of `\hypertarget`.
> + Use `\hyperref` for LaTeX internal links, `\hyperlink` for
>   beamer (since `\hyperref` doesn't seem to work).
>
>   Closes #9022.
@hseg
Copy link
Contributor Author

hseg commented Sep 3, 2023

Unsure why nix build is failing, though

@lierdakil
Copy link
Owner

Unsure why nix build is failing, though

In all likelihood, you just need to bump hackage.nix in flake.lock (e.g. nix flake update). But feel free to ignore it.

This Pandoc update, however, is a problem, see #402. We need to remove label generation from equations, apparently 🤔

@hseg
Copy link
Contributor Author

hseg commented Sep 3, 2023

Ah, missed that. That will require better understanding of these codepaths than I possess, hope I at least gave something of value.

@lierdakil
Copy link
Owner

The update required non-trivial changes to the output, so I've opted to do those manually. In any case, thanks for the PR, sorry I didn't merge it.

@lierdakil lierdakil closed this Sep 23, 2023
@hseg
Copy link
Contributor Author

hseg commented Sep 23, 2023 via email

@lierdakil
Copy link
Owner

lierdakil commented Sep 23, 2023

Golden tests in test/m2m are relatively easy to regenerate, essentially find -iname input.md | while read i; do pandoc $i -F pandoc-crossref -t markdown-raw_attribute-raw_html -o ${i%/input.md}/expect.md; done and similar for -t latex.

Golden tests in test/test-pandoc-crossref.hs kinda have to be done manually. It may be worth converting at least some of those to something more manageable -- certainly at least the LaTeX group (which is statistically the most problematic in terms of Pandoc updates) can be converted to files. The code there is pretty gnarly, though.

@hseg hseg deleted the verbump-pandoc-3.1.7 branch September 24, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants