-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url-polyfill is loaded in Safari when not required #14
Comments
I find the same problem.When I use url-polyfill and pdfjs-dist in my web,the url-polyfill will lose efficacy. Because pdf-dist use this code to check if URL is valid. More over ,If this is a bug ? url-polyfill use this code to check URL is supported.But after execute the module .The check is false also in safari. |
I don't have Safari on the hand. Could you fix it on your side, run the tests and create a pull request please ? |
This is still an issue in Safari 10. Any idea what should be the fix? |
@janicklas-ralph I dont have any Safari on the hand, could you please fork the project, fix the bug, and then do a pull request ? |
Ok, version 1.1.8 released. Tell if everything is OK |
Seems to be because Safari escapes the pathname set by url-polyfill.js#L173, causing the comparison
(u.href === 'http://a/c%20d')
to return false:The text was updated successfully, but these errors were encountered: