Handle read deadlocks #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL has in internal read buffer that needs to be drained. Since we, by default, read in 4K chunks, anything larger would have left data to be read that may not have been processed properly. Also, we need to handle SSL_ERROR_WANT_READ and SSL_ERROR_WANT_WRITE exceptions around the recv() and send() calls, otherwise we would think we are disconnected and cause all sorts of problems.
When using multiple job servers, some connections may not yet be established (not been chosen yet), so their socket is still invalid. This would cause poller.register() to throw an exception.
Address some SSL handling issues.
This reverts commit 2ea5ca7.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to latest upstream, reverted our last bug fix that is now unnecessary and add some handling for deadlocks when server and worker are both trying to read