Update lint library #140
Merged
Update lint library #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidTanner
requested review from
xdumaine,
IevgenRagulin,
macsj200,
rmneidermyer and
swain
swain
approved these changes
Jun 30, 2022
Comment on lines
+3
to
+4
| "@lifeomic/standards/javascript", | ||
| "@lifeomic/standards/typescript" |
There was a problem hiding this comment.
Do we need both of these? I thought typescript inherited from javascript
There was a problem hiding this comment.
You are right, but in the next one I change this anyways to use the root, since I'm switching tests to jest.
xdumaine
approved these changes
Jun 30, 2022
|
🎉 This PR is included in version 5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update linting in anticipation of better things to come. Jest, full typescript, and aws-sdk v3