Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing direct dependency @aws-sdk/url-parser #155

Conversation

austinkelleher
Copy link

@austinkelleher
Copy link
Author

cc @DavidTanner @mdlavin

@swain swain self-requested a review July 3, 2023 19:29
@shawnzhu
Copy link
Member

shawnzhu commented Jul 3, 2023

FYI: this will avoid the break change when upgrading to @aws-sdk/client-lambda@^2.363.0 (where @aws-sdk/url-parser was renamed to @smithy@url-parser via aws/aws-sdk-js-v3#4873)

@swain
Copy link
Contributor

swain commented Jul 3, 2023

@austinkelleher Thanks for this PR Austin, and sorry for the delay in feedback.

It looks great. We have a security control that requires all of our commits to be signed + verified (even from the public) -- that's why CI on this PR is red. Would you be willing to amend your commit to be signed?

This Gist provides a straightforward guide for setting up commit signing: https://gist.github.com/Beneboe/3183a8a9eb53439dbee07c90b344c77e

If you'd rather not spend time setting up commit signing, I'm afraid the only option is for us to merge a different PR with the fix here. Happy to make that fix myself, but you'd lose your contribution -- just let me know how you'd like to proceed.

@swain
Copy link
Contributor

swain commented Jul 6, 2023

@austinkelleher Didn't hear back from you on the above, so we went ahead and released the fix via a different PR. Thanks for raising this issue!

The fix is available in version 5.1.3.

@swain swain closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants