Fix header class detection

lifeomic · Oct 4, 2022 · 6cb0b17 · 6cb0b17
1 parent 3532f5d
commit 6cb0b17
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/typeUtils.ts b/src/typeUtils.ts
@@ -15,7 +15,7 @@ export function createFetchHeaders (axiosHeaders: Record<string, string> = {}):
   return headers;
 }
 
-const isHeaders = (headers: HeadersLike): headers is Headers => headers.constructor.name === 'Headers';
+const isHeaders = (headers: HeadersLike): headers is Headers => headers.constructor?.name === 'Headers';
 
 export function createAxiosHeaders (headers: HeadersLike = {}): Record<string, string> {
   const rawHeaders: Record<string, string> = {};

diff --git a/test/typeUtils.test.ts b/test/typeUtils.test.ts
@@ -1,10 +1,10 @@
 import test from 'ava';
+import { Headers as NodeHeaders, Request } from 'node-fetch';
 import {
   createAxiosHeaders,
   createFetchHeaders,
   getUrl
 } from '../src/typeUtils';
-import { Request, Headers as NodeHeaders } from 'node-fetch';
 
 const headersObject = {
   key1: 'value1',
@@ -40,6 +40,10 @@ test('createAxiosHeaders will return an empty object on undefined', (t) => {
   t.deepEqual(createAxiosHeaders({ 'undefined': undefined }), {});
 });
 
+test('createAxiosHeaders will work with Headers object without a prototype', (t) => {
+  t.deepEqual(createAxiosHeaders(Object.create(null)), {});
+});
+
 test('createAxiosHeaders will format fetch style Headers object for Axios', (t) => {
   t.deepEqual(createAxiosHeaders(headersClass), headersObject);
 });