Fix header class detection #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requested review from a random This review is not blocking and is for broader awareness. Consider if this change requires deeper security review and ask when it is necessary. |
|
Thank you for your contribution! It's perfect ❤️ . Clear description, fix and a testcase. I'm running the tests now and I'll merge when it passes |
mdlavin
approved these changes
Oct 4, 2022
|
Oh bummer. I forgot we require commit signing. @ecl1ps any chance you could force push a signed commit with the same change? |
This was referenced Oct 5, 2022
Merged
|
Done, signed. But it seems I am too late :D |
|
Your change was so good, and I couple other people reported it. I cheated and merged without a signature. Thanks again |
|
Glad to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you create a new object by using
Object.create(null)then this new instance doesn't inherit from anything. It meansObject.create(null).constructor === undefined(https://stackoverflow.com/a/15518712/14750967). And that is the error we are encountering and this PR is fixing.That is the way how
apollo/client@3.7is preparing headers which are then passed toaxios-fetchhttps://github.com/apollographql/apollo-client/blob/9134aaf3b6fc398b2d82439b5b63848b533ae4c9/src/link/http/selectHttpOptionsAndBody.ts#L203.This is a regression caused by the following cleanup commit 33d6962.
Added test to reproduce this problem.