Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for undefined body #64

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

hogpilot
Copy link
Contributor

Checks if init.body is defined before converting it to a string in axiosFetch method.

Fixes #63

@coveralls
Copy link

coveralls commented Mar 16, 2021

Pull Request Test Coverage Report for Build 270

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 267: 0.0%
Covered Lines: 16
Relevant Lines: 16

💛 - Coveralls

@mdlavin
Copy link
Member

mdlavin commented Mar 16, 2021

@hogpilot Thank you for contributing a fix and your change looks good to me. Would you mind adding a testcase to make sure that it doesn't get regressed by future changes?

@mdlavin mdlavin merged commit 3f1b9f5 into lifeomic:master Mar 17, 2021
@mdlavin
Copy link
Member

mdlavin commented Mar 17, 2021

@hogpilot Double thanks for the fix and test. I'll wait on the update on the PR and will release a new version after that one merges too

@hogpilot
Copy link
Contributor Author

@mdlavin Thanks for your quick review. I appreciate the test reminder

@mdlavin
Copy link
Member

mdlavin commented Mar 17, 2021

This fixe long with #62 should be included in @lifeomic/axios-fetch@1.5.2

@hogpilot hogpilot deleted the data-undefined branch March 17, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET requests have data as string "undefined"
3 participants