Throw original error on network error #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axios errors do not contain a `response` attribute when there is no response (ex. network errors).
jagoda
commented
Jun 29, 2021
| @@ -55,7 +55,11 @@ async function axiosFetch ( | |||
| try { | |||
| result = await axios.request(config); | |||
| } catch (err) { | |||
| result = err.response; | |||
| if (err.response) { | |||
There was a problem hiding this comment.
Without this change the original error is masked by a new error: TypeError: Cannot read property 'headers' of undefined.. This is because the code below assumes that response is defined and attempts to read attributes from it.
DavidTanner
approved these changes
Jun 29, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Axios errors do not contain a
responseattribute when there isno response (ex. network errors).