Don't wait for aborted builds forever #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IevgenRagulin
force-pushed
the
AbortedBuildsIssue
branch
from
375a9eb
to
86d07c9
Compare
mdlavin
requested changes
Oct 31, 2020
| timestamp = response.data.timestamp; | ||
| } while (timestamp); | ||
|
|
||
| const attributes = await describeBuild({ appSlug, buildSlug, client }); | ||
|
|
||
| if (attributes.status > 1) { |
There was a problem hiding this comment.
Will this fail if the break on line 50 is hit before fetching the attributes? This file needs TypeScript for safety
There was a problem hiding this comment.
Great catch! I've fixed this. Turns out one of the unit tests was failing because of this ("following a successful build that has already finished prints the log output"), but somehow I didn't notice this. Would you mind if I convert this to typescript in a follow-up PR?
There was a problem hiding this comment.
I like the idea of a TypeScript conversion
mdlavin
previously approved these changes
Nov 3, 2020
| timestamp = response.data.timestamp; | ||
| } while (timestamp); | ||
|
|
||
| const attributes = await describeBuild({ appSlug, buildSlug, client }); | ||
|
|
||
| if (attributes.status > 1) { |
There was a problem hiding this comment.
I like the idea of a TypeScript conversion
mdlavin
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This jenkins build keeps watching the bitrise build that has been aborted hours ago:
https://jenkins.infra.lifeomic.com/blue/organizations/jenkins/life-extend/detail/PR-4050/46/pipeline/140