Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typings and allow default export #9

Merged
merged 2 commits into from
Aug 9, 2019

Conversation

0xch4z
Copy link
Contributor

@0xch4z 0xch4z commented Aug 8, 2019

  • Allow TS consumers to use the default export
  • Allow importing as createClient named symbol
  • Decouple App and Client types
  • Fix wrongly typed integers from codegen (don't know why my editor didn't yell at me, type is actually being resolved as any).

@0xch4z 0xch4z requested review from jagoda and mdlavin August 8, 2019 21:06
index.d.ts Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Aug 8, 2019

Pull Request Test Coverage Report for Build 55

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 49: 0.0%
Covered Lines: 81
Relevant Lines: 81

💛 - Coveralls

@0xch4z
Copy link
Contributor Author

0xch4z commented Aug 9, 2019

Unfortunately with this method, I can't export our type definitions, but it works.

@mdlavin
Copy link
Member

mdlavin commented Aug 9, 2019 via email

@0xch4z 0xch4z merged commit 8da3763 into master Aug 9, 2019
@0xch4z 0xch4z deleted the fix-typings-and-allow-default-export branch August 9, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants