Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Re-evaluate Modal component props #204

Closed
ynotdraw opened this issue Oct 13, 2021 · 1 comment
Closed

Proposal: Re-evaluate Modal component props #204

ynotdraw opened this issue Oct 13, 2021 · 1 comment

Comments

@ynotdraw
Copy link
Contributor

ynotdraw commented Oct 13, 2021 •
edited
Loading

We should re-evaluate the Modal component props. In particular, size and fullWidth are extremely confusing. We have some feedback on this on #116 (comment). What would be nice is if we have a new height and width props, with four different size options for each, allowing a bit deeper customization.

We can make this a breaking change if it makes sense, or provide new props and deprecate the old ones. We could even look at replacing the underpinnings with another library that may help us out a bit too 👍
@HaleyWardo
Copy link
Contributor

Ticket created - CHROM-196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ynotdraw @HaleyWardo