Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Add a new component ReactTable #330

Closed
wants to merge 1 commit into from
Closed

[PoC] Add a new component ReactTable #330

wants to merge 1 commit into from

Conversation

shawnzhu
Copy link
Member

Goal

bring in the row selection capability by using react-table's API.

Progress

it works by adding a new module named ReactTable.

it will be lots of work to include react-table as a new Chroma component besides TableModule, will be lots of work to maintain and deprecate TableModule afterwards.

Conclusion

Based on the similarity of react-table and TableModule API , it would be easier to just refactor TableModule by adding react-table as implementation and make it backward compatible.

  • when using config of TableModule, no changes to existing apps that use it.
  • when using columns: ColumnRef[] to configure TableModule , it will use react-table 's implementation.

@shawnzhu shawnzhu added the enhancement New feature or request label Mar 17, 2023
@lifeomic-probot
Copy link

🚩 No commit messages matched the required convention
<type>: my commit message

Valid types: feat, fix, docs, style, refactor, perf, test, chore, build, revert

You'll need to either:

See the conventional-commits spec for more details.

Created by lifeomic-probot (Enforce Semantic Commits)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant