[PoC] Add a new component ReactTable #330
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
bring in the row selection capability by using react-table's API.
Progress
it works by adding a new module named
ReactTable
.it will be lots of work to include react-table as a new Chroma component besides
TableModule
, will be lots of work to maintain and deprecateTableModule
afterwards.Conclusion
Based on the similarity of
react-table
andTableModule
API , it would be easier to just refactorTableModule
by addingreact-table
as implementation and make it backward compatible.config
ofTableModule
, no changes to existing apps that use it.columns: ColumnRef[]
to configure TableModule , it will use react-table 's implementation.