fix: allow a wider range of @lifeomic/alpha versions #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlavin
commented
Sep 20, 2023
| @@ -67,7 +67,7 @@ | |||
| "typescript": "*" | |||
| }, | |||
| "devDependencies": { | |||
| "@lifeomic/alpha": "^5.0.1", | |||
| "@lifeomic/alpha": "^4.1.0", | |||
There was a problem hiding this comment.
Alpha 5.0 requires the AWS SDK 3.0 and this project is built around the 2.0 SDK. Don't pull the 3.0 SDK for development
| @@ -123,7 +123,7 @@ | |||
| "@elastic/elasticsearch": "^7.3.0", | |||
| "archiver": "^3.0.0", | |||
| "ava": "^3.13.0", | |||
| "aws-sdk": "^2.290.0", | |||
| "aws-sdk": "^2.1001.0", | |||
There was a problem hiding this comment.
Match the requirement in alpha ^4.1.0. The version deployed to AWS lambdas is currently 2.1374.0 so this version is safe.
| @@ -153,7 +153,7 @@ | |||
| "access": "public" | |||
| }, | |||
| "peerDependencies": { | |||
| "@lifeomic/alpha": "^5.0.1", | |||
| "@lifeomic/alpha": "^4.1.0 || ^5.0.1", | |||
There was a problem hiding this comment.
If somebody wants an AWS SDK v3 version, that's fine, they both work
mdlavin
force-pushed
the
allow-wider-range-of-alpha
branch
from
4f02b3c
to
0babd9d
Compare
swain
previously approved these changes
Sep 21, 2023
mdlavin
dismissed
swain’s stale review
The merge-base changed after approval.
swain
previously approved these changes
Sep 21, 2023
mdlavin
dismissed
swain’s stale review
The merge-base changed after approval.
hemp
previously approved these changes
Sep 21, 2023
mdlavin
dismissed
hemp’s stale review
The merge-base changed after approval.
hemp
previously approved these changes
Sep 21, 2023
mdlavin
dismissed
hemp’s stale review
The merge-base changed after approval.
hemp
previously approved these changes
Sep 21, 2023
mdlavin
dismissed
hemp’s stale review
The merge-base changed after approval.
mdlavin
force-pushed
the
allow-wider-range-of-alpha
branch
from
0babd9d
to
442e89b
Compare
hemp
approved these changes
Sep 21, 2023
Pull Request Test Coverage Report for Build 6263267098
💛 - Coveralls |
|
🎉 This PR is included in version 16.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.