-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: require specifying a top-level account
#450
Conversation
Merging this PR will result in a major version bump. Created by lifeomic-probot (Enforce Semantic Commits) |
efb2cda
to
96858dc
Compare
Pull Request Test Coverage Report for Build 6813696300Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
90f7305
to
f1fcbae
Compare
189309e
to
3aaf060
Compare
3aaf060
to
b387987
Compare
b387987
to
27b0207
Compare
d74c268
to
11e9135
Compare
11e9135
to
2125f52
Compare
account
account
I'm re-opening a newer, cleaner PR here. |
Changes
Reviewers: I highly recommend reviewing this change:
I've intentionally separated the change into three commits:
Updating the core logic in
useActiveAccount
+useActiveProject
Updating the
ActiveAccountProvider
call sites.Updating the
useActiveAccount
call sites.