Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: require specifying a top-level account #450

Closed
wants to merge 3 commits into from

Conversation

swain
Copy link
Contributor

@swain swain commented Nov 9, 2023

Changes

Reviewers: I highly recommend reviewing this change:

  • by commit, and
  • with Hide Whitespace Changes

I've intentionally separated the change into three commits:

  • Updating the core logic in useActiveAccount + useActiveProject

  • Updating the ActiveAccountProvider call sites.

  • Updating the useActiveAccount call sites.

@lifeomic-probot
Copy link

lifeomic-probot bot commented Nov 9, 2023

⚠️ Detected a breaking change in commit 94ec6ff

Merging this PR will result in a major version bump.

Created by lifeomic-probot (Enforce Semantic Commits)

@swain swain force-pushed the force-single-account branch 3 times, most recently from efb2cda to 96858dc Compare November 9, 2023 14:38
@coveralls
Copy link

coveralls commented Nov 9, 2023

Pull Request Test Coverage Report for Build 6813696300

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 27 of 34 (79.41%) changed or added relevant lines in 10 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 83.641%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useActivities.tsx 0 2 0.0%
src/hooks/useWearables.ts 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
src/hooks/Circles/useLoadReplies.ts 1 85.29%
src/hooks/useConversations.ts 1 32.14%
Totals Coverage Status
Change from base Build 6813542978: -0.1%
Covered Lines: 3144
Relevant Lines: 3654

💛 - Coveralls

@swain swain force-pushed the force-single-account branch 3 times, most recently from 90f7305 to f1fcbae Compare November 9, 2023 15:09
@swain swain changed the title try account Require specifying a top-level account Nov 9, 2023
@swain swain changed the base branch from master to require-project-and-account-before-children November 20, 2023 22:34
Base automatically changed from require-project-and-account-before-children to master November 22, 2023 16:54
@swain swain force-pushed the force-single-account branch 2 times, most recently from d74c268 to 11e9135 Compare November 22, 2023 17:12
@swain swain changed the base branch from master to refactor-project November 22, 2023 17:12
@swain swain changed the base branch from refactor-project to master November 22, 2023 17:29
@swain swain changed the title Require specifying a top-level account feat!: require specifying a top-level account Nov 22, 2023
@swain
Copy link
Contributor Author

swain commented Nov 22, 2023

I'm re-opening a newer, cleaner PR here.

@swain swain closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants