FLME-340: invalidate activities list when consent is accepted #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7072141838
💛 - Coveralls |
swain
force-pushed
the
FLME-340
branch
6 times, most recently
from
391085d
to
9a8f36b
Compare
swain
changed the title
swain
requested review from
markdlv,
sternetj,
nicolls1,
aecorredor,
jkdowdle and
bruce-glazier
aecorredor
approved these changes
Dec 4, 2023
| @@ -25,7 +25,7 @@ jest.mock('./useHttpClient', () => ({ | |||
| const useActiveProjectMock = useActiveProject as jest.Mock; | |||
| const useHttpClientMock = useHttpClient as jest.Mock; | |||
|
|
|||
| const renderHookInContext = (useHook: Function) => { | |||
| const renderHookInContext = <T extends any>(useHook: () => T) => { | |||
There was a problem hiding this comment.
What's the reason for extending any here?
Comment on lines
+50
to
+51
| queryClient.resetQueries({ queryKey: ACTIVITIES_QUERY_KEY }); | ||
| await options?.onSuccess?.(data, variables); |
There was a problem hiding this comment.
Should we leave a comment here about why we refresh the activities on refresh? It might not be obvious for other devs in the future.
There was a problem hiding this comment.
Absolutely. I'll follow-up with that.
|
🎉 This PR is included in version 9.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If a user has been enrolled into a program before their first login, we need to refresh their activity list whenever they accept a consent. Accepting consent can result in new activities showing up.
Screenshots