fix: consent screen use mutate over async mutate #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkdowdle
requested review from
markdlv,
sternetj,
nicolls1,
aecorredor,
swain and
bruce-glazier
swain
reviewed
Dec 1, 2023
src/hooks/useConsent.ts
Outdated
Comment on lines
21
to
27
| options: UseMutationOptions< | ||
| PatchConsentDirectives['Response'], | ||
| unknown, | ||
| PatchConsentDirectives['Request'] & { | ||
| directiveId: string; | ||
| } | ||
| > = {}, |
There was a problem hiding this comment.
Rather than provide the full options here, can we just provide an onSuccess option? That will simplify the typing a lot, and make a soon-to-come change from me a lot easier.
jkdowdle
force-pushed
the
switch-mutate
branch
from
e4357d3
to
394b576
Compare
jkdowdle
changed the title
Pull Request Test Coverage Report for Build 7063285931Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
swain
approved these changes
Dec 1, 2023
|
🎉 This PR is included in version 9.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mutateovermutateAsync, makes using it a bit simpler especially in the custom screen flowScreenshots