fix: improve invite already accepted handling #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swain
force-pushed
the
improve-invite-already-accepted-handling
branch
from
ed30510
to
d5b9fd0
Compare
Pull Request Test Coverage Report for Build 7350645555
💛 - Coveralls |
mdlavin
reviewed
Dec 28, 2023
| } | ||
|
|
||
| if (typeof response !== 'object') { | ||
| return; |
There was a problem hiding this comment.
Should this return a true or false?
mdlavin
reviewed
Dec 28, 2023
| if ( | ||
| 'error' in response && | ||
| typeof response.error === 'string' && | ||
| response.error.includes('already accepted') |
There was a problem hiding this comment.
Should the API be modified to have a consistent behavior instead of two ways to return the same thing?
There was a problem hiding this comment.
@mdlavin Yes, it definitely should. I'd like to consider that change out-of-scope for this PR.
FWIW, as far as I can tell, the behavior is consistent. But, the current SDK logic is simply not correct. I'd like to get this sub-optimal extra handling in place, then follow-up with a deeper investigation to simplify the logic (client-side, server-side, or both)
mdlavin
approved these changes
Dec 28, 2023
|
🎉 This PR is included in version 11.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This handling seems to have become incorrect over the past few months. This makes it correct.
Screenshots