Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Same Day Data in Sleep Charts #508

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Handle Same Day Data in Sleep Charts #508

merged 1 commit into from
Jan 4, 2024

Conversation

sternetj
Copy link
Contributor

@sternetj sternetj commented Jan 4, 2024

Changes

  • Wearables such as HealthKit can collect data from multiple wearables. This can result in overlapping sleep data that describes the same sleep event. This change adds logic to only use a single observation per day when displaying the sleep information. We group all data by the start of the effective day and then use the observation with the most components (attempt to use the most granular data).

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7413880499

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 84.702%
Totals Coverage Status
Change from base Build 7413303168: 0.03%
Covered Lines: 3484
Relevant Lines: 4005
💛 - Coveralls

@sternetj sternetj merged commit e615a1a into master Jan 4, 2024
3 checks passed
@sternetj sternetj deleted the handle-same-day-sleep-data branch January 4, 2024 20:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 4, 2024

🎉 This PR is included in version 11.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdlv markdlv markdlv approved these changes

@bruce-glazier bruce-glazier Awaiting requested review from bruce-glazier

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
3 participants
@sternetj @coveralls @markdlv