Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Filter Conversation Notification Badge #516

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: Filter Conversation Notification Badge #516

merged 1 commit into from
Jan 15, 2024

Conversation

sternetj
Copy link
Contributor

Changes

  • Adds logic to filter the conversation notification badge to only be true if there are conversations within the message tile that have unread messages

Screenshots

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7531468586

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.204%
Totals Coverage Status
Change from base Build 7489673850: 0.2%
Covered Lines: 3617
Relevant Lines: 4128
💛 - Coveralls

@sternetj sternetj merged commit 47e9ba1 into master Jan 15, 2024
3 checks passed
@sternetj sternetj deleted the filter-conversation-notification-badge branch January 15, 2024 22:08
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markdlv markdlv markdlv approved these changes

@bruce-glazier bruce-glazier bruce-glazier approved these changes

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
4 participants
@sternetj @coveralls @markdlv @bruce-glazier