Upgrade React Native Paper and Fix Warnings #518
Conversation
| @@ -111,7 +111,6 @@ export const SearchRecipientsModal = ({ | |||
| mode="contained" | |||
| style={styles.doneButton} | |||
| labelStyle={styles.doneButtonLabel} | |||
| compact={true} | |||
There was a problem hiding this comment.
After the upgrade this was causing the button text to be truncated
sternetj
force-pushed
the
fix-warnings
branch
from
26c09da
to
9d8ee9b
Compare
Pull Request Test Coverage Report for Build 7543867449
💛 - Coveralls |
sternetj
force-pushed
the
fix-warnings
branch
from
9d8ee9b
to
21f7bca
Compare
| width: '90%', | ||
| marginHorizontal: '5%', |
There was a problem hiding this comment.
Spacing is now handled by the modal. Spacing on the modal was necessary to achieve the same style while also setting a background to avoid the RTCView warning.
| @@ -152,7 +149,6 @@ const defaultStyles = createStyles('SearchRecipientsModal', (theme) => { | |||
| marginVertical: 16, | |||
| marginRight: 16, | |||
| height: 35, | |||
| width: 55, | |||
There was a problem hiding this comment.
After the upgrade this was causing the text to be truncated.
| @@ -32,7 +32,7 @@ export const TraceLine = (props: Props) => { | |||
| const yDomain = [domainMin, domainMax] as [number, number]; | |||
|
|
|||
| const trend = useMemo(() => { | |||
| if (showTrend) { | |||
| if (showTrend && data.length > 1) { | |||
There was a problem hiding this comment.
We should only show the trend if it has 2+ points. A single point produces a flat trend which isn't meaningful and 0 points causes a NaN error because of division by zero.
| @@ -35,6 +35,7 @@ export function ScreenSurface({ | |||
| const defaultStyles = createStyles('ScreenSurface', (theme) => ({ | |||
| surfaceView: { | |||
| flex: 1, | |||
| height: '100%', | |||
There was a problem hiding this comment.
After the upgrade a react native paper surface must have a height set to flex properly.
| @@ -56,7 +56,7 @@ export const BottomNavigationBar = ({ | |||
| ? options.tabBarLabel | |||
| : options.title !== undefined | |||
| ? options.title | |||
| : route.title; | |||
| : route.name; | |||
There was a problem hiding this comment.
After the upgrade the title property was removed. We now default to name, however, in practice this should never happen.
| @@ -122,8 +122,7 @@ export function MessageScreen<ParamList extends ParamListBase>({ | |||
| <View | |||
| style={{ | |||
| flexDirection: 'row', | |||
| flex: 1, | |||
| maxWidth: 60, | |||
| width: 60, | |||
There was a problem hiding this comment.
After the upgrade the message avatars did not display correctly. Setting a static width solved this problem.
|
🎉 This PR is included in version 11.11.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Changes
RCTView has a shadow set but cannot calculate shadow efficientlyhiddenstyle from PillarsTile as it also triggered aRCTView has a shadow set but cannot calculate shadow efficientlywarningRCTView has a shadow set but cannot calculate shadow efficientlywarningRCTView has a shadow set but cannot calculate shadow efficientlywarningAdvancedTrackerEditorto be serializable to avoid aNon-serializable values were found in the navigation state.warningAdvancedTrackerEditorsave button to avoid aReact has detected a change in the order of Hookserror when setting the right header optionScreenshots
Here is a video of everything work correctly:
react-native-paperupgrdae-demo.mov