Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize My Data Screen Performance #519

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

sternetj
Copy link
Contributor

Changes

  • Fixes an issue with the LineChart TrendLine computing an infinite slope
  • Adds a loader to the LineChart
  • Adds enabled props to all charts to control when searching occurs
  • Hides DataSelector for LineChart when not enabled. When view a year's worth of data, the component creates a lot of children which causes the render to be slow. This hides the DataSelector for non-enabled charts. Ultimately this needs to be reworked but it's okay for now
  • Fixes a bug with sleep chart multiday selection where trying to select a chart with no data caused an error
  • Adds the ability provide a Header to the SurfaceView. This is useful for providing a fixed header
  • Fixes the styles of the DatePicker to fit in a flex layout better and to have a shadow to since it should be slightly elevated
  • Adds scroll observing behavior to only fetch data for charts that are visible to the user
  • Extracts the range selector control so it is more responsive to touches and uses a debounced change method to prevent the my data charts from refetching too soon

Screenshots

my-data-optimizations.mov

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7627834931

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 85.061%

Totals Coverage Status
Change from base Build 7558119092: -0.2%
Covered Lines: 3651
Relevant Lines: 4170

💛 - Coveralls

@sternetj sternetj merged commit 9175b53 into master Jan 24, 2024
3 checks passed
@sternetj sternetj deleted the optimize-my-data-screen branch January 24, 2024 13:38
Copy link

🎉 This PR is included in version 11.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
3 participants