Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add handling for multiple consents #528

Merged
merged 1 commit into from
Feb 7, 2024
Merged

feat: Add handling for multiple consents #528

merged 1 commit into from
Feb 7, 2024

Conversation

bruce-glazier
Copy link
Contributor

Changes

  • Handle multiple consent assigments

Screenshots

Simulator.Screen.Recording.-.iPhone.14.-.2024-02-07.at.14.05.41.mp4

@coveralls
Copy link

coveralls commented Feb 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7820386524

  • -2 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 85.067%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hooks/useConsent.ts 9 11 81.82%
Totals Coverage Status
Change from base Build 7816123400: -0.03%
Covered Lines: 3672
Relevant Lines: 4193
💛 - Coveralls

sternetj
sternetj reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@sternetj sternetj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just need to remove the example app change.

example/AppDemo.tsx Outdated Show resolved Hide resolved
@bruce-glazier bruce-glazier merged commit c9ec0de into master Feb 7, 2024
3 checks passed
@bruce-glazier bruce-glazier deleted the handle-multiple-consents branch February 7, 2024 20:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

🎉 This PR is included in version 11.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternetj sternetj sternetj approved these changes

@swain swain Awaiting requested review from swain

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
3 participants
@bruce-glazier @coveralls @sternetj