Start using @lifeomic/react-client #531
Conversation
nicolls1
changed the title
nicolls1
changed the title
Pull Request Test Coverage Report for Build 7974737404Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
nicolls1
requested review from
swain,
bruce-glazier,
aecorredor,
sternetj and
jkdowdle
|
I believe I updated all for all of the current features in |
| @@ -6,8 +6,8 @@ import axios, { | |||
| } from 'axios'; | |||
| import { useAuth } from './useAuth'; | |||
| import { APIClient } from '@lifeomic/one-query'; | |||
| import { RestAPIEndpoints } from '../types/rest-types'; | |||
There was a problem hiding this comment.
Can we now delete the types defined in this file?
There was a problem hiding this comment.
Yep, +1 -- there are several big type defs defined in this project that should be deleted.
- fhir api types
- rest api types
- auth api types
There was a problem hiding this comment.
I had a bunch of test errors come up when deleting and moving over so I assumed we needed both but will remove.
| @@ -104,6 +113,36 @@ export const useConsent = () => { | |||
| useConsentDirectives, | |||
| useUpdateProjectConsentDirective, | |||
| useShouldRenderConsentScreen, | |||
| } as { | |||
There was a problem hiding this comment.
See slack or the failed earlier builds. Happy to fix some other way but that is what was decided there.
There was a problem hiding this comment.
We are not building the FL member app as an SDK is probably the biggest difference.
| Route extends keyof Endpoints & string, | ||
| Data = Endpoints[Route]['Response'], | ||
| >( | ||
| route: Route, | ||
| payload: RequestPayloadOf<Endpoints, Route>, | ||
| options?: RestrictedUseQueryOptions< | ||
| Endpoints[Route]['Response'], | ||
| unknown, | ||
| Data | ||
| >, |
There was a problem hiding this comment.
Why did we need this explicit type? I think we didn't have it when we used the library on the FL member app.
There was a problem hiding this comment.
See slack or the failed earlier builds. Happy to fix some other way but that is what was decided there.
There was a problem hiding this comment.
We are not building the FL member app as an SDK is probably the biggest difference.
|
To be clear, tests are working but the build is what is requiring these explicit types because of this setting ts config setting |
|
🎉 This PR is included in version 11.17.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Changes
@lifeomic/react-clientScreenshots