Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Track Tile Bugs #532

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Fix Track Tile Bugs #532

merged 1 commit into from
Feb 19, 2024

Conversation

sternetj
Copy link
Contributor

Changes

  • Disables the pillar plus button when loading to prevent creating a new record before current records load
  • Use the trackerValue when updating the value instead of first trackerValue in the list. This fixes a bug when decreasing a value across two records. Example We have A:1 and B:3 (id:value). We decrease the tracker value by 2. Prior to the change we would delete A and then try to update value A to be 2. This tracks the id/value correctly now so we will delete A and update B to be 2.
  • Adds a first variable to the fetch query with a value of 200. When a user used the history chart and they had more than 10 values for the period (a common case if tracking daily for more than one pillar/tracker), only partial data would be returned and the user would think the values were gone. Because of the caching behavior of the axios track tile service, when going to the individual data of an unloaded value, the value would show 0 instead of the actual value which caused users to re-add the data.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7962503942

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.075%

Totals Coverage Status
Change from base Build 7905759218: 0.0%
Covered Lines: 3684
Relevant Lines: 4207

💛 - Coveralls

Copy link
Contributor

@bruce-glazier bruce-glazier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes, huge impact, nice!

@sternetj sternetj merged commit a1df60c into master Feb 19, 2024
3 checks passed
@sternetj sternetj deleted the fix-track-tile-bugs branch February 19, 2024 17:19
Copy link

🎉 This PR is included in version 11.17.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
3 participants