Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skip invite params #535

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Allow skip invite params #535

merged 1 commit into from
Feb 29, 2024

Conversation

bruce-glazier
Copy link
Contributor

Changes

  • Add config option to not forward inviteId and evc to the auth session

@bruce-glazier bruce-glazier changed the title fix: allow skip invite params Allow skip invite params Feb 29, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8101690199

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 85.07%
Totals Coverage Status
Change from base Build 7991514404: -0.007%
Covered Lines: 3687
Relevant Lines: 4210
💛 - Coveralls

rob-snyder
rob-snyder approved these changes Feb 29, 2024
View reviewed changes
Copy link

@rob-snyder rob-snyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this so Readout members can get into the app without receiving an invite from our platform?

@bruce-glazier
Copy link
Contributor Author

Is this so Readout members can get into the app without receiving an invite from our platform?

It is so Readout members do not trigger the evc flow in auth-apps. Since they are using SSO we do not want a user account automatically created for them by the invite/evc.

@bruce-glazier bruce-glazier merged commit eedaeee into master Feb 29, 2024
3 checks passed
@bruce-glazier bruce-glazier deleted the allow-skip-invite-params branch February 29, 2024 20:16
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 11.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternetj sternetj sternetj approved these changes

@rob-snyder rob-snyder rob-snyder approved these changes

@swain swain Awaiting requested review from swain

Assignees
No one assigned
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
Milestone
No milestone
4 participants
@bruce-glazier @coveralls @sternetj @rob-snyder