Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add messaging placeholder #541

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

bruce-glazier
Copy link
Contributor

Changes

  • Add explanation for when the messages screen is empty
  • Add explanation for when the compose messaging screen has no recipients

Screenshots

Screenshot 2024-03-21 at 9 33 51 AM Screenshot 2024-03-21 at 9 44 43 AM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8376508069

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 84.977%

Totals Coverage Status
Change from base Build 8359344161: -0.04%
Covered Lines: 3702
Relevant Lines: 4231

💛 - Coveralls

@@ -236,6 +236,18 @@ export function MessageScreen<ParamList extends ParamListBase>({
</TouchableOpacity>
</Swipeable>
))}
{!conversations?.length && !isLoading && (
<Swipeable>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I try to swipe this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since no swipeable left or right props are passed, nothing happens.

@bruce-glazier bruce-glazier merged commit aa5c336 into master Mar 27, 2024
3 checks passed
@bruce-glazier bruce-glazier deleted the add-messaging-placeholders branch March 27, 2024 12:48
Copy link

🎉 This PR is included in version 11.17.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Has been released to the package repository (NPM, etc) label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Has been released to the package repository (NPM, etc)
Projects
None yet
3 participants