feat: Add app switcher button #545
Conversation
| const { activeProject } = useActiveProject(); | ||
|
|
||
| const query = useRestQuery( | ||
| 'GET /v1/life-research/projects/:projectId/app-config', | ||
| 'GET /v1/life-research/projects/:projectId/app-configs/list', |
There was a problem hiding this comment.
Somewhere we will need to make this smarter, probably at the API level. Currently this list will contain all configs that exist for the project but an App user should likely only be able to change between configs that they belong to (cohort or user list). This is probably okay until we identify how to manage that logic. I imagine it could end up being different per client.
There was a problem hiding this comment.
Total oversight on my part, I'll work on updating API side
bruce-glazier
force-pushed
the
add-user-app-config-switching
branch
from
97c7b31
to
cf09858
Compare
bruce-glazier
force-pushed
the
add-user-app-config-switching
branch
from
cf09858
to
dee2c87
Compare
Pull Request Test Coverage Report for Build 8693577141Details
💛 - Coveralls |
| appTiles: mockAppTiles, | ||
| }, | ||
|
|
||
| // Bug in mocker seems to not be able to tell /:id and /list apart |
There was a problem hiding this comment.
I think it is thinking that list is the :id. Did you try swapping the definition order of the route mocks? It seems like msw/node prepends the routes so I would think/hope that mocking /:id then mocking /list would produce the desired result. Regardless though this seems fine.
There was a problem hiding this comment.
I'd expect that if /list matches multiple routes that the mocking library would prefer the exact match over the wildcard which is sort of why I described this as a bug but perhaps you are right about that.
|
🎉 This PR is included in version 12.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Changes
Screenshots