Add logout button to bail #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruce-glazier
force-pushed
the
improve-wait-for-subject-id
branch
from
7176827
to
e1114cf
Compare
Pull Request Test Coverage Report for Build 9162006822Details
💛 - Coveralls |
rob-snyder
reviewed
May 20, 2024
| @@ -32,6 +36,9 @@ export function ActivityIndicatorView({ | |||
| </Text> | |||
| ) : null; | |||
|
|
|||
| const secondTimeoutComponents = | |||
| !!children && !!showChildren() ? children : null; | |||
There was a problem hiding this comment.
I'm not following what this is for...
There was a problem hiding this comment.
In the attached video, at around the 45 second mark, you can see the Logout button appear. The idea is that after some secondary timeout you can have the child components rendered. Does that answer your question?
rob-snyder
approved these changes
May 20, 2024
sternetj
approved these changes
May 20, 2024
|
🎉 This PR is included in version 12.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-05-20.at.12.36.20.mp4