README badges #59
README badges #59
Conversation
markdlv
force-pushed
the
PHC-4152-readme-badges
branch
from
8aca5f2
to
6242d2f
Compare
package.json
Outdated
| @@ -13,6 +13,7 @@ | |||
| "lint:fix": "yarn lint --fix", | |||
| "test": "yarn jest", | |||
| "test:ci": "yarn lint && yarn jest --coverage --runInBand --silent --ci --logHeapUsage", | |||
| "coverage": "cat ./coverage/lcov.info | coveralls", | |||
There was a problem hiding this comment.
What does this do exactly? Looking at the library it pushes it to coveralls.io but isn't that what the github action is for?
There was a problem hiding this comment.
🤔 spot on. I'm not even calling yarn coverage within this PR 🤦. This is nice for testing/debugging, but it doesn't really need to be in package.json/yarn.lock - removing.
There was a problem hiding this comment.
Gotcha 👍, I was confused and thought you knew something I didn't because the action's own docs points you at that library and I thought maybe it called that command internally or something.
There was a problem hiding this comment.
👍 glad to turn around and add it back if the master merge fails, but pretty sure the Github Action is self-sufficient - worked successfully on PR. We'll see for sure here in a minute.
markdlv
force-pushed
the
PHC-4152-readme-badges
branch
from
6242d2f
to
643fe5d
Compare
|
🎉 This PR is included in version 1.1.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions
bot
added
the
released
No description provided.