Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose full path to resource #14

Merged
merged 3 commits into from
Jul 31, 2018
Merged

Expose full path to resource #14

merged 3 commits into from
Jul 31, 2018

Conversation

Druotic
Copy link
Contributor

@Druotic Druotic commented Jul 30, 2018

E.g.

{
...
      "module": "test1.test2",
      "type": "null_resource",
      "name": "test2",
      "path": "module.test1.module.test2.null_resource.test2",
...
}

Exposing the path is very convenient for consumers and it's already in memory/computed anyway. It avoids having to try and rebuild the path based on the module, name, (data) type, etc.

@Druotic
Copy link
Contributor Author

Druotic commented Jul 30, 2018

lockfile changes aren't related to my change - but I bumped them in a separate commit to capture the recent greenkeeper bumps that didn't check in the associated lockfile changes.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 62

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 60: 0.0%
Covered Lines: 161
Relevant Lines: 161

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 30, 2018

Pull Request Test Coverage Report for Build 67

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 60: 0.0%
Covered Lines: 161
Relevant Lines: 161

💛 - Coveralls

Copy link
Contributor

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change

@Druotic
Copy link
Contributor Author

Druotic commented Jul 31, 2018

Oops! Forgot docs. Added.

@@ -121,9 +121,9 @@ The output is an object with these top-level properties:
Each _changed resource_ has the following properties:

- **`action`:** One of `"create"`, `"destroy"`, `"replace"`, `"update"`
- **`module`:** Name of a module that contains a resource (only present when module is not `root`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted since this is a duplicate description, and the other description is better IMO.

@philidem philidem merged commit 84fdf67 into master Jul 31, 2018
@philidem
Copy link
Contributor

Published terraform-plan-parser@1.5.0

@hemp hemp deleted the expose-full-path branch July 24, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants