Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-137638 allow s tag on sanitizer configuration #494

Closed
wants to merge 3 commits into from
Closed

[TS] LPS-137638 allow s tag on sanitizer configuration #494

wants to merge 3 commits into from

Conversation

ericyanLr
Copy link

Hi team,

Can you help review this PR?

Notes from @leticia-maciel:

Issue: CKEditor uses the <s> tag to strike through the words on body text but Questions portlet and Message Board execute the Anti Sanitizer method before saving on the database and it was filtering the <s> tag. That was happening because the sanitizer-configuration.xml did not have the <s> tag added on its tag-rules to accept the tag and not filter it.

Fix: The <s> tag was added on tag-rules on sanitizer-configuration.xml by build.gradle. Similar case on LPS-91238.

Please let us know if you have any questions.
Thanks!

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ericyanLr ericyanLr mentioned this pull request Sep 16, 2021
Closed
@ericyanLr
Copy link
Author

ci:test:sf

@ericyanLr
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb

Sender Branch:

Branch Name: pr-245_leticia-maciel_LPS-137638
Branch GIT ID: 96aa69fae1cd3d6293f80a6dd4c99865bf7e2146

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 1 hour 51 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb

Upstream Comparison:

Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb
Jenkins Build URL: Acceptance Upstream DXP (master) #2322

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 23 out of 23 jobs PASSED
23 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@stian-sigvartsen
Copy link
Collaborator

Thanks @ericyanLr !

@stian-sigvartsen
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#107409
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@ericyanLr @liferay-continuous-integration @stian-sigvartsen