Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMERCE-7239 Set guest checkout authentication content cacheable to false #1757

Closed
wants to merge 1 commit into from

Conversation

dsitu
Copy link
Collaborator

@dsitu dsitu commented Sep 16, 2021

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 16, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb

Sender Branch:

Branch Name: COMMERCE-7239
Branch GIT ID: f67c6049f78da3beea6ebd1fe3c155dad9ab97de

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: For better performance, the variable declaration for 'cacheable' should be moved inside the if-statement on line '322': ./modules/apps/commerce/commerce-product-service/src/main/java/com/liferay/commerce/product/internal/importer/CPFileImporterImpl.java 311 (Checkstyle:VariableDeclarationAsUsedCheck)
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:458)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:287)
[stopwatch] [run.batch.test.action: 52.581 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-32/job/test-portal-source-format/379//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210916124955769.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210916124955769.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1923393523.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[beanshell] Truncating errors in /opt/dev/projects/github/liferay-portal/portal-impl/test-results/TEST-JenkinsLogAssertTest.xml
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null997882908
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 160ms
[junitreport] Deleting: /tmp/null997882908
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results
[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results
[echo] run.batch.test.tear.down.start.timestamp: 09-16-2021 12:49:57:628 PDT
[stopwatch] [run.batch.test.tear.down: 0.000 sec]

@liferay-continuous-integration
Copy link
Collaborator

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 16, 2021

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb

Sender Branch:

Branch Name: COMMERCE-7239
Branch GIT ID: e89a09e47874d091761b9f386aa29608c1aa0a9b

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@dsitu
Copy link
Collaborator Author

dsitu commented Sep 16, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 60 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb

Upstream Comparison:

Branch GIT ID: 2e1ff16e8938589891df0d6e796214f74446abfb
Jenkins Build URL: Acceptance Upstream DXP (master) #2322

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 2e1ff16:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    2945 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1 #116
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=74507, name=com.liferay.portal.kernel.model.Layout, primKey=44, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=74507, name=com.liferay.portal.kernel.model.Layout, primKey=44, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1068)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...
    2. AXIS_VARIABLE=4 #116
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=89887, name=com.liferay.portal.kernel.model.Layout, primKey=42, scope=4}
        com.liferay.portal.kernel.events.ActionException: java.lang.IllegalArgumentException: Someone may be trying to circumvent the permission checker: {companyId=89887, name=com.liferay.portal.kernel.model.Layout, primKey=42, scope=4}
        	at com.liferay.portal.events.ServicePreAction.run(ServicePreAction.java:153)
        	at com.liferay.portal.kernel.events.Action.processLifecycleEvent(Action.java:34)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:80)
        	at com.liferay.portal.events.EventsProcessorUtil.process(EventsProcessorUtil.java:52)
        	at com.liferay.portal.internal.servlet.MainServlet._processServicePre(MainServlet.java:1068)
        	at com.liferay.portal.internal.servlet.MainServlet.service(MainServlet.java:556)
        	at javax.servlet.http.HttpServlet.service(HttpServlet.java:733)
        	at com.liferay.shielded.container.internal.proxy.ServletWrapper.service(ServletWrapper.java:113)
        	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
        	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
        	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
        	at org.apache.catalina.core.ApplicationFilterChain.in...

@liferay-continuous-integration
Copy link
Collaborator

@ivicac
Copy link

ivicac commented Sep 17, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#107389
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants