COMMERCE-5061 Fix order transfering from guest to new user #599

alecsloan · 2021-02-05T21:03:08Z

No description provided.

liferay-continuous-integration · 2021-02-05T21:03:13Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

alecsloan · 2021-02-05T21:03:34Z

ci:test:sf

alecsloan · 2021-02-05T21:03:43Z

ci:test:relevant

liferay-continuous-integration · 2021-02-05T21:12:04Z

❌ ci:test:sf - 0 out of 1 jobs passed in 8 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1d55df8bb0fe334fa8ff83afb01440de7dd9ad06

Sender Branch:

Branch Name: COMMERCE-5061
Branch GIT ID: fd0ae4c37f7b5b642300c018df9c60dedafe8380

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/commerce/commerce-checkout-web/src/main/java/com/liferay/commerce/checkout/web/internal/portlet/CommerceCheckoutPortlet.java expected:<...gPool.POUND +
     [java] 						[	]commerceOrder.getGro...> but was:<...gPool.POUND +
     [java] 						[]commerceOrder.getGro...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:445)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:290)
[stopwatch] [run.batch.test.action: 6:52.639 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-22/job/test-portal-source-format/6162//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210205131152130.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210205131152130.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1077433790.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null581236335

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 230ms

[junitreport] Deleting: /tmp/null581236335

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-05-2021 13:11:57:082 PST

[stopwatch] [run.batch.test.tear.down: 0.001 sec]

[echo]

[echo] Ant GC log:

[echo]

liferay-continuous-integration · 2021-02-06T00:14:24Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 2 hours 55 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1d55df8bb0fe334fa8ff83afb01440de7dd9ad06

Upstream Comparison:

Branch GIT ID: 5c53d15efecfc71faa21658cfb68eb40fb65c93a
Jenkins Build URL: Acceptance Upstream DXP (master) #1521

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 23 out of 23 jobs PASSED

23 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2021-02-06T02:10:41Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7769
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-commerce#599
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - alecsloan > liferay-commerce - PR#599 - 2021-02-05[13:03:55]
Spira Jenkins Build:publish-spira-report#15110

liferay-continuous-integration · 2021-02-06T03:33:28Z

Jenkins Build:test-portal-source-format#6162
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-commerce#599
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - alecsloan > liferay-commerce - PR#599 - 2021-02-05[13:03:45]
Spira Jenkins Build:publish-spira-report#11090

ivicac · 2021-02-08T13:47:55Z

ci:test:sf

liferay-continuous-integration · 2021-02-08T13:51:18Z

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 79236b4c10bea5e9f9d2d25339081ffe5fb586a0

Sender Branch:

Branch Name: COMMERCE-5061
Branch GIT ID: fd0ae4c37f7b5b642300c018df9c60dedafe8380

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/commerce/commerce-checkout-web/src/main/java/com/liferay/commerce/checkout/web/internal/portlet/CommerceCheckoutPortlet.java expected:<...gPool.POUND +
     [java] 						[	]commerceOrder.getGro...> but was:<...gPool.POUND +
     [java] 						[]commerceOrder.getGro...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:445)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:290)
[stopwatch] [run.batch.test.action: 1:44.032 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-8/job/test-portal-source-format/4254//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210208055101883.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210208055101883.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null36131580.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null293990817

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 3411ms

[junitreport] Deleting: /tmp/null293990817

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 02-08-2021 05:51:10:600 PST

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

ivicac · 2021-02-08T14:01:45Z

@alecsloan can you please fix SF?

liferay-continuous-integration · 2021-02-08T18:46:07Z

Jenkins Build:test-portal-source-format#4254
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-commerce#599
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - alecsloan > liferay-commerce - PR#599 - 2021-02-08[05:48:06]
Spira Jenkins Build:publish-spira-report#11169

alecsloan · 2021-02-09T01:07:40Z

ci:test:sf

alecsloan · 2021-02-09T01:07:44Z

ci:test:relevant

ivicac · 2021-02-10T12:18:41Z

@alecsloan can you please rebase PR as Brian has ported some commits from 7.3.x PR, but not everything

alecsloan · 2021-02-10T18:34:35Z

ci:test:sf

alecsloan · 2021-02-10T18:34:45Z

ci:test:relevant

liferay-continuous-integration · 2021-02-10T18:40:31Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 643b6ca9d7b0ce0d199b5d3d8f41c33c15e30456

Sender Branch:

Branch Name: COMMERCE-5061
Branch GIT ID: 7c217a4aa0dc9037db48394d53dc0dd8a697ae83

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-02-10T19:13:30Z

Jenkins Build:test-portal-source-format#4267
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-commerce#599
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - alecsloan > liferay-commerce - PR#599 - 2021-02-10[10:35:15]
Spira Jenkins Build:publish-spira-report#15420

liferay-continuous-integration · 2021-02-10T22:03:10Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 3 hours 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 643b6ca9d7b0ce0d199b5d3d8f41c33c15e30456

Upstream Comparison:

Branch GIT ID: a00ac7e5d3877a05468293478418f238b3d03bb3
Jenkins Build URL: Acceptance Upstream DXP (master) #1538

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 23 out of 23 jobs PASSED

23 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2021-02-11T03:32:14Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6847
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-commerce#599
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - alecsloan > liferay-commerce - PR#599 - 2021-02-10[10:59:25]
Spira Jenkins Build:publish-spira-report#12743

ivicac · 2021-02-11T12:47:17Z

ci:forward

liferay-continuous-integration · 2021-02-11T12:47:20Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-02-11T12:47:21Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-02-11T12:48:25Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2021-02-11T12:48:43Z

Pull request has been successfully forwarded to brianchandotcom#98670

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - failure and removed ci:test:sf - pending labels Feb 5, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 6, 2021

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - failure labels Feb 8, 2021

ivicac self-requested a review February 8, 2021 13:48

liferay-continuous-integration added ci:test:sf - failure and removed ci:test:sf - pending labels Feb 8, 2021

alecsloan force-pushed the COMMERCE-5061 branch from fd0ae4c to 1b4225a Compare February 9, 2021 01:06

liferay-continuous-integration added ci:test:sf - pending and removed ci:test:sf - failure labels Feb 9, 2021

dsitu approved these changes Feb 9, 2021

View reviewed changes

COMMERCE-5445 When the order is placed delete the order cookie

7c217a4

alecsloan force-pushed the COMMERCE-5061 branch from 6a99157 to 7c217a4 Compare February 10, 2021 18:24

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Feb 10, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - success ci:test:stable - success labels Feb 10, 2021

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Feb 10, 2021

ivicac approved these changes Feb 11, 2021

View reviewed changes

liferay-continuous-integration mentioned this pull request Feb 11, 2021

COMMERCE-5061 Fix order transfering from guest to new user brianchandotcom/liferay-portal#98670

Closed

liferay-continuous-integration closed this Feb 11, 2021

COMMERCE-5061 Fix order transfering from guest to new user #599

COMMERCE-5061 Fix order transfering from guest to new user #599

Conversation

alecsloan commented Feb 5, 2021

liferay-continuous-integration commented Feb 5, 2021

alecsloan commented Feb 5, 2021

alecsloan commented Feb 5, 2021

liferay-continuous-integration commented Feb 5, 2021

❌ ci:test:sf - 0 out of 1 jobs passed in 8 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Feb 6, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 2 hours 55 minutes

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Feb 6, 2021

liferay-continuous-integration commented Feb 6, 2021

ivicac commented Feb 8, 2021

liferay-continuous-integration commented Feb 8, 2021

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

ivicac commented Feb 8, 2021

liferay-continuous-integration commented Feb 8, 2021

alecsloan commented Feb 9, 2021

alecsloan commented Feb 9, 2021

ivicac commented Feb 10, 2021

alecsloan commented Feb 10, 2021

alecsloan commented Feb 10, 2021

liferay-continuous-integration commented Feb 10, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Feb 10, 2021

liferay-continuous-integration commented Feb 10, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 23 jobs passed in 3 hours 2 minutes

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Feb 11, 2021

ivicac commented Feb 11, 2021

liferay-continuous-integration commented Feb 11, 2021

liferay-continuous-integration commented Feb 11, 2021

liferay-continuous-integration commented Feb 11, 2021

liferay-continuous-integration commented Feb 11, 2021