LPS-167148 Remove "immediate = true" from Echo components part 2 #2525

we found out why the JournalArticleIndexer becomes satisfied after the re-indexing process. There was an issue in ServiceTrackerListImpl.removedService() that is calling the ungetService twice. So, as those Indexers are referenced only by trackers in the IndexerRegistryImpl and SearchEngineInitializer#_reindex, the additional call is causing the *Indexer services to deactivate and stay in the satisfied state since there are no more references for that service.

PS: We've tested with others Indexes implementations and we faced the same issue.

Thx

rafaprax · 2022-11-22T13:50:45Z

ci:test:echo

rafaprax · 2022-11-22T13:51:07Z

ci:test:startup

liferay-continuous-integration · 2022-11-22T17:47:18Z

						<h1>Unable to generate test report.</h1><p>Jenkins encountered the following error while generating test report:</p><pre><code>Sourced file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : TargetError : at Line: 48 : in file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : throw e ;

Target exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.NullPointerException

Base Branch:

Branch Name: master

Branch GIT ID: 50e751808d803f59bd4036290d63fa2df0f5c36e

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-22T17:51:56Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3228

Jenkins Report:jenkins-report.html

Jenkins Suite:startup

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:startup - rafaprax > liferay-core-infra - PR#2525 - 2022-11-22[07:37:09]

Testray Importer:publish-testray-report#7924

liferay-continuous-integration · 2022-11-22T17:58:02Z

❌ ci:test:echo - 483 out of 511 jobs passed in 2 hours 39 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 50e751808d803f59bd4036290d63fa2df0f5c36e

Upstream Comparison:

Branch GIT ID: 50e751808d803f59bd4036290d63fa2df0f5c36e
Jenkins Build URL: EE Development Acceptance (master) - 4046 - 2022-11-22[05:12:32]

ci:test:echo - 483 out of 511 jobs PASSED

28 Failed Jobs:

483 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-jdk8/17/19

print-jstack-logs:
     [echo] Executing commands: 
     [echo] 
     [echo] jps > jps_output
     [echo] 
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
[stopwatch] [test.execution.duration: 15:26.163 sec]
[stopwatch] [run.batch.test.action: 15:39.635 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1678: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1682: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:39: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:51: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14604: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16045: Timeout: killed the sub-process
      [get] Getting: ${dependencies.url}/archive/test-1-26/test-portal-acceptance-pullrequest-downstream(master)/333206consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20221122090335561.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20221122090335561.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1891943958.properties

functional-tomcat90-mysql57-jdk8/0/7
1. LocalFile.NavigationMenuWidget#ViewCustomFieldOfNavigationMenu - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/1/17
1. LocalFile.ContentPagesWithMapping#ViewMapInformationAfterDeleteMappedPage - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/1/21
1. LocalFile.ContentPagesWithExperiencePersonalization#ViewCollectionItemsOnContentPageWhenSelectSegment - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/2/4
...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-22T18:07:30Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5209

Jenkins Report:jenkins-report.html

Jenkins Suite:echo

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:echo - rafaprax > liferay-core-infra - PR#2525 - 2022-11-22[07:18:44]

Testray Importer:publish-testray-report#12609

liferay-continuous-integration · 2022-11-22T20:18:48Z

✔️ ci:test:stable - 28 out of 28 jobs passed

❌ ci:test:relevant - 222 out of 271 jobs passed in 3 hours 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 50e751808d803f59bd4036290d63fa2df0f5c36e

Upstream Comparison:

Branch GIT ID: 50e751808d803f59bd4036290d63fa2df0f5c36e
Jenkins Build URL: EE Development Acceptance (master) - 4046 - 2022-11-22[05:12:32]

ci:test:stable - 28 out of 28 jobs PASSED

28 Successful Jobs:

ci:test:relevant - 222 out of 271 jobs PASSED

49 Failed Jobs:

222 Successful Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-22T20:34:04Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#2510

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - rafaprax > liferay-core-infra - PR#2525 - 2022-11-22[08:35:38]

Testray Importer:publish-testray-report#5502

zhangyan0701 · 2022-11-24T10:41:23Z

No regressions found.

liferay-continuous-integration · 2022-11-28T14:58:05Z

						<h1>Unable to generate test report.</h1><p>Jenkins encountered the following error while generating test report:</p><pre><code>Sourced file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : TargetError : at Line: 48 : in file: inline evaluation of: `` 						 							import com.liferay.jenkins.results.parser.Build; 							import co . . . '' : throw e ;

Target exception: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.NullPointerException

Base Branch:

Branch Name: master

Branch GIT ID: e56aff76be7cb4dbdebbb3eb2730fb199918ac2c

Job Summary:

Job Link: test-portal-acceptance-pullrequest(master)

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-28T15:02:24Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6112

Jenkins Report:jenkins-report.html

Jenkins Suite:startup

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:startup - rafaprax > liferay-core-infra - PR#2525 - 2022-11-28[04:49:11]

Testray Importer:publish-testray-report#15538

liferay-continuous-integration · 2022-11-28T16:21:28Z

✔️ ci:test:stable - 28 out of 28 jobs passed

❌ ci:test:relevant - 194 out of 248 jobs passed in 3 hours 28 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1297401_5576

Base Branch:

Branch Name: master
Branch GIT ID: e56aff76be7cb4dbdebbb3eb2730fb199918ac2c

Upstream Comparison:

Branch GIT ID: b5d0ff22da454ed670f0865f6ae1f966ff911141
Jenkins Build URL: EE Development Acceptance (master) - 4063 - 2022-11-27[05:05:25]

ci:test:stable - 28 out of 28 jobs PASSED

28 Successful Jobs:

ci:test:relevant - 194 out of 248 jobs PASSED

54 Failed Jobs:

194 Successful Jobs:

For more details click here.

Failures unique to this pull:

modules-integration-mysql57-jdk8/3/20
```
Build was aborted
```

Failures in common with acceptance upstream results at b5d0ff2:

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-28T16:49:55Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5576

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - rafaprax > liferay-core-infra - PR#2525 - 2022-11-28[04:46:15]

Testray Importer:publish-testray-report#13711

Kvale1733 · 2022-11-29T19:22:07Z

ci:test:echo

liferay-continuous-integration · 2022-11-29T21:36:19Z

❌ ci:test:echo - 432 out of 476 jobs passed in 2 hours 13 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1327401_7158

Base Branch:

Branch Name: master
Branch GIT ID: 1436eaf47e4a1f49a1a7fe4c1e51fa00cad41a71

Upstream Comparison:

Branch GIT ID: 2ec68618ff9ab83cbff7d983041ec0628b2eb7ca
Jenkins Build URL: EE Development Acceptance (master) - 4071 - 2022-11-29[07:38:31]

ci:test:echo - 432 out of 476 jobs PASSED

44 Failed Jobs:

432 Successful Jobs:

For more details click here.

Failures unique to this pull:

functional-tomcat90-mysql57-jdk8/16/9

print-jstack-logs:
     [echo] Executing commands: 
     [echo] 
     [echo] jps > jps_output
     [echo] 
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
[stopwatch] [test.execution.duration: 15:23.554 sec]
[stopwatch] [run.batch.test.action: 15:36.520 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1632: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1636: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:39: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:51: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:14609: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:16050: Timeout: killed the sub-process
      [get] Getting: ${dependencies.url}/archive/test-1-28/test-portal-acceptance-pullrequest-downstream(master)/271666consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20221129122500776.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20221129122500776.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1271929823.properties

functional-tomcat90-mysql57-jdk8/0/7
1. LocalFile.AssetPublisherUseCase#ViewDocumentTypeShownInManualSelection - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/2/2
1. LocalFile.AssetPublisherUseCase#FilterDocumentsByField - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/2/7
1. LocalFile.ContentDisplayWithWebContentTemplate#ViewSelectedWebContentWithMultipleSelectionField - Poshi Report - Poshi Summary - Console Output
functional-tomcat90-mysql57-jdk8/2/13
1. LocalFile.ContentDisplayWithWebContentTemplate#ViewSelectedWebContentWithSelectFromListField - Poshi Report - Poshi Summary - Console Output
...

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

liferay-continuous-integration · 2022-11-29T21:53:46Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7158

Jenkins Report:jenkins-report.html

Jenkins Suite:echo

Pull Request:liferay-core-infra#2525

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:echo - rafaprax > liferay-core-infra - PR#2525 - 2022-11-29[11:22:20]

Testray Importer:publish-testray-report#18007

catarineaguiar · 2022-11-30T14:33:56Z

@rafaprax no regressions found.

rafaprax · 2022-11-30T14:36:49Z

@shuyangzhou conflicts were fixed and it is ready for your review. Thx

tinatian · 2022-11-30T17:15:40Z

.../java/com/liferay/osgi/service/tracker/collections/internal/list/ServiceTrackerListImpl.java

@@ -174,8 +174,6 @@ public void removedService(
 			_serviceTrackerCustomizer.removedService(serviceReference, service);

 			_update(serviceReference, service, true);
-


@rafaprax Please fix this in a separate ticket and add test to cover it.

Thanks.

tinatian · 2022-11-30T17:16:35Z

@rafaprax I am going to close this pull, I believe other changes depends on the fix of service tracker list, please resend after the service tracker list bug fix is merged.

Thanks.
Tina

rafaprax · 2022-12-02T18:28:55Z

resent here #2613

rafaprax mentioned this pull request Nov 22, 2022

LPS-167148 Remove "immediate = true" from Echo components part 2 #2286

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Nov 22, 2022

liferay-continuous-integration added ci:test:echo - pending ci:test:startup - pending ci:test:relevant - pending ci:test:stable - pending ci:test:startup - failure and removed ci:test:startup - pending labels Nov 22, 2022

liferay-continuous-integration added ci:test:echo - failure and removed ci:test:echo - pending labels Nov 22, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 22, 2022

zhangyan0701 added the QA Passed label Nov 24, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:startup - pending ci:test:startup - failure and removed ci:test:stable - success ci:test:startup - failure ci:test:startup - pending labels Nov 28, 2022

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 28, 2022

rafaprax removed the QA Passed label Nov 29, 2022

liferay-continuous-integration added ci:test:echo - pending ci:test:echo - failure and removed ci:test:echo - failure ci:test:echo - pending labels Nov 29, 2022

catarineaguiar added the QA Passed label Nov 30, 2022

tinatian reviewed Nov 30, 2022

View reviewed changes

tinatian closed this Nov 30, 2022

		@@ -174,8 +174,6 @@ public void removedService(
		_serviceTrackerCustomizer.removedService(serviceReference, service);

		_update(serviceReference, service, true);

LPS-167148 Remove "immediate = true" from Echo components part 2 #2525

LPS-167148 Remove "immediate = true" from Echo components part 2 #2525

Conversation

rafaprax commented Nov 22, 2022

liferay-continuous-integration commented Nov 22, 2022

liferay-continuous-integration commented Nov 22, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 22, 2022

rafaprax commented Nov 22, 2022 • edited

rafaprax commented Nov 22, 2022

rafaprax commented Nov 22, 2022

liferay-continuous-integration commented Nov 22, 2022

Base Branch:

Job Summary:

Test bundle downloads:

liferay-continuous-integration commented Nov 22, 2022

liferay-continuous-integration commented Nov 22, 2022

❌ ci:test:echo - 483 out of 511 jobs passed in 2 hours 39 minutes

Base Branch:

Upstream Comparison:

28 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Nov 22, 2022

liferay-continuous-integration commented Nov 22, 2022

✔️ ci:test:stable - 28 out of 28 jobs passed

❌ ci:test:relevant - 222 out of 271 jobs passed in 3 hours 40 minutes

Base Branch:

Upstream Comparison:

49 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Nov 22, 2022

zhangyan0701 commented Nov 24, 2022

liferay-continuous-integration commented Nov 28, 2022

Base Branch:

Job Summary:

Test bundle downloads:

liferay-continuous-integration commented Nov 28, 2022

liferay-continuous-integration commented Nov 28, 2022

✔️ ci:test:stable - 28 out of 28 jobs passed

❌ ci:test:relevant - 194 out of 248 jobs passed in 3 hours 28 minutes

Base Branch:

Upstream Comparison:

54 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Nov 28, 2022

Kvale1733 commented Nov 29, 2022

liferay-continuous-integration commented Nov 29, 2022

❌ ci:test:echo - 432 out of 476 jobs passed in 2 hours 13 minutes

Base Branch:

Upstream Comparison:

44 Failed Jobs:

For more details click here.

Failures unique to this pull:

Test bundle downloads:

liferay-continuous-integration commented Nov 29, 2022

catarineaguiar commented Nov 30, 2022

rafaprax commented Nov 30, 2022

tinatian Nov 30, 2022

Choose a reason for hiding this comment

tinatian commented Nov 30, 2022

rafaprax commented Dec 2, 2022

rafaprax commented Nov 22, 2022 •

edited