Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-119645 Setting dataType of image field as 'image' #13

Closed
wants to merge 1 commit into from

Conversation

mateussgn
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@mateussgn mateussgn changed the title LPS-119645 Setting dataType as 'image' and setting the alt attribute LPS-119645 Setting dataType of image field as 'image' Oct 20, 2020
@jeyvison
Copy link

Just started reviewing :)

:octocat: Sent from GH.

@jeyvison
Copy link

Just started reviewing :)

:octocat: Sent from GH.

@jeyvison
Copy link

jeyvison commented Nov 3, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0b197df59d70576cdf03f05525c7a49caf76d8e1

Sender Branch:

Branch Name: LPS-119645
Branch GIT ID: 57f9646c50e56eb90cf17c6785f6dfd6a0e7d603

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 4 hours 20 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: afb229df01a027b6f438bf1628290d9470d1e4d8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 8 out of 9 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at afb229d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #310148

      Please fix semantic versioning on mateussgn/LPS-119645

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec] * com.liferay.dynamic.data.mapping.form.field.type   CHANGED    1.8.0      1.8.0      1.8.1      VERSION INCREASE REQUIRED
           [exec] 	~   interface  com.liferay.dynamic.data.mapping.form.field.type.DDMFormFieldTypeSettings
           [exec] 		~   method     fieldReference()
           [exec] 			~   annotated  com.liferay.dynamic.data.mapping.annotations.DDMFormField
           [exec] 				+   property   properties.0='tooltip=%field-reference-serves-as-a-frienldy-identifier'
           [exec] 				-   property   required=true
           [exec] 		~   method     name()
           [exec] 			~   annotated  com.liferay.dynamic.data.mapping.annotations.DDMFormField
           [exec] 				+   property   visibilityExpression='FALSE'
           [exec] 	~   interface  com.liferay.dynamic.data.mapping.form.field.type.DefaultDDMFormFieldTypeSettings
           [exec] 		~   method     fieldReference()
           [exec] 			~   annotated  com.liferay.dynamic.data.mapping.annotations.DDMFormField
           [exec] 				+   property   properties.0='tooltip=%field-reference-serves-as-a-frienldy-identifier'
           [exec] 				-   property   required=true
           [exec] 		~   method     name()
           [exec] 			~   annotated  com.liferay.dynamic.data.mapping.annotations.DDMFormField
           [exec] 				+   property   visibilityExpression='FALSE'
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.dynamic.data.mapping.api-9.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.dynamic.data.mapping.api/8.9.1/c01706f413c9315b67126cfa5aad0b1229513781/com.liferay.dynamic.data.mapping.api-8.9.1.jar

@liferay-continuous-integration
Copy link
Collaborator

@mateussgn
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 3 hours 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 8dd8349f3a2ff73ae02eb15adef344286e575fdb

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 24 out of 26 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 8dd8349:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #454877

      Please fix semantic versioning on mateussgn/LPS-119645

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
           [exec] = ================================================== ========== ========== ========== ========== ==========
           [exec]   com.liferay.dynamic.data.mapping.form.field.type   UNCHANGED  1.8.0      1.8.1      1.8.1      VERSION INCREASE SUGGESTED
           [exec] 	+   version    1.8.0
           [exec] 	-   version    1.8.1
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.dynamic.data.mapping.api-9.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.dynamic.data.mapping.api/8.10.0/3172f873905dbdcf5973699172cc73a8581ccc88/com.liferay.dynamic.data.mapping.api-8.10.0.jar

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Closed pull request will not be forwarded.

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants