Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-128158 Don't validate that options is translated for all the languages since it is not required. As other localized values, having the default language translation is enough #275

Closed
wants to merge 2 commits into from
Closed

LPS-128158 Don't validate that options is translated for all the languages since it is not required. As other localized values, having the default language translation is enough #275

wants to merge 2 commits into from

Conversation

victorg1991
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 0 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Sender Branch:

Branch Name: options_LPS-128158
Branch GIT ID: 4ae72c06e96f92ad7d8277ab863844647f8848f8

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@jeyvison jeyvison added the Review Pending The PR needs to be reviewed before forwarding to Brian label Feb 25, 2021
@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5293
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-data-engine#275
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - victorg1991 > liferay-data-engine - PR#275 - 2021-02-25[03:46:12]
Spira Jenkins Build:publish-spira-report#16554

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 26 out of 26 jobs passed in 0 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Upstream Comparison:

Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96
Jenkins Build URL: Acceptance Upstream DXP (master) #1578

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 26 out of 26 jobs PASSED
26 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#5396
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-data-engine#275
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-data-engine - PR#275 - 2021-02-25[04:30:53]
Spira Jenkins Build:publish-spira-report#13658

@marcelabc marcelabc added the blocked PR should not be fowarded to Brian. Another PR is blocking the progress label Feb 25, 2021
@marcelabc
Copy link

marcelabc commented Feb 25, 2021 •
edited

Hi @victorg1991 😄
I had to block this PR from forwarding because your solution was not ideal. Your commit message's content is right, but and you are trying to avoid the use of "validateDDMFormPropertyValue," but we really should use it.

DDMFormValidatorImpl is used for many projects. We should not change the way of validating the field properties.
I know that Data Engine has this new rule of not obligating the translation for all languages, but there are projects that this is still the valid rule.

Our team had a solution to catch the exception in another class, inside the DE module, and avoid this case from happening. I just found out that this was refactored(liferay@7306908), and I have to talk with the dev to understand his needs.

I will be responsible for this LPS from now on, okay?
Thank you for your work!! Let me know if you have any questions.

@victorg1991
Copy link
Author

Hey @marcelabc !

I read the comments and find a another way to do it, so I've given another try, I've used the same approach used for other properties :) Let me know what do you think

Thanks! :)

@marcelabc marcelabc self-assigned this Feb 26, 2021
@marcelabc
Copy link

Just started reviewing :)

:octocat: Sent from GH.

@marcelabc
Copy link

Hi @victorg1991 ,
Thank you for the work! It's really nice, I will forward to Brian 🎉

@marcelabc marcelabc added Good to go This PR can be forwarded and removed Review Pending The PR needs to be reviewed before forwarding to Brian blocked PR should not be fowarded to Brian. Another PR is blocking the progress labels Feb 26, 2021
@marcelabc
Copy link

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: edbe530802cd2803c20096473a079a0349be2fd9

Sender Branch:

Branch Name: options_LPS-128158
Branch GIT ID: c6f390a043904ca3681b45bb95cbd8eb85b01408

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4362
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-data-engine#275
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - victorg1991 > liferay-data-engine - PR#275 - 2021-02-26[08:18:01]
Spira Jenkins Build:publish-spira-report#20525

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 26 out of 26 jobs passed in 2 hours 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: edbe530802cd2803c20096473a079a0349be2fd9

Upstream Comparison:

Branch GIT ID: a7369cd8a329290d391ff22422e5945311ab5a8e
Jenkins Build URL: Acceptance Upstream DXP (master) #1583

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 26 out of 26 jobs PASSED
26 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#99301

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#6967
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-data-engine#275
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-data-engine - PR#275 - 2021-02-26[08:38:19]
Spira Jenkins Build:publish-spira-report#16504

@victorg1991 victorg1991 deleted the options_LPS-128158 branch March 23, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcelabc marcelabc

Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success Good to go This PR can be forwarded
Projects
None yet
Milestone
No milestone
4 participants
@victorg1991 @liferay-continuous-integration @marcelabc @jeyvison