Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-131912 if value is not localized, the value for all the available locales is overwritten #420

Closed
wants to merge 1 commit into from
Closed

LPS-131912 if value is not localized, the value for all the available locales is overwritten #420

wants to merge 1 commit into from

Conversation

rodrigopaulino
Copy link

@rodrigopaulino rodrigopaulino commented May 11, 2021 •
edited

Related ticket: https://issues.liferay.com/browse/LPS-131912

@AliciaGarciaGarcia,

Your idea seems to work, but I moved the "localizable" validation two "ifs" up to avoid having to iterate the available locales with no purpose.

Thanks for contributing.

@rodrigopaulino @AliciaGarciaGarcia
LPS-131912 if value is not localized, the value for all the available…
51e8842 
… locales is overwritten

Co-authored-by: Alicia Garcia <alicia.garcia@liferay.com>
@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@rodrigopaulino rodrigopaulino changed the title LPS 131912 LPS-131912 if value is not localized, the value for all the available locales is overwritten May 11, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffd0befc13449e6c0863104e000f812b8ceee005

Sender Branch:

Branch Name: LPS-131912
Branch GIT ID: 51e88427e45227e8ec1fffe67206e182892d66b6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@rodrigopaulino rodrigopaulino added the Good to go This PR can be forwarded label May 11, 2021
@rodrigopaulino rodrigopaulino mentioned this pull request May 11, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffd0befc13449e6c0863104e000f812b8ceee005

Upstream Comparison:

Branch GIT ID: ffd0befc13449e6c0863104e000f812b8ceee005
Jenkins Build URL: Acceptance Upstream DXP (master) #1851

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 24 out of 26 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ffd0bef:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #386558
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620771940995.log:
!SESSION 2021-05-11 22:26:09.549 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.click.to.chat.web 4 0 2021-05-11 22:26:09.550
        
!MESSAGE FrameworkEvent ERROR
        
!STACK 0
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.click.to.chat.web [1187]
        
Unresolved requirement: Require-Capability: osgi.extender; filter:="(&(osgi.extender=jsp.taglib)(uri=http://liferay.com/tld/learn))"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManage...</code></pre></div></li><li><div><a href="https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/386558//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 

        

        FrameworkEvent ERROR
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.click.to.chat.web [1187]
        
Unresolved requirement: Require-Capability: osgi.extender; filter:="(&(osgi.extender=jsp.taglib)(uri=http://liferay.com/tld/learn))"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:274...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>

@liferay-continuous-integration
Copy link
Collaborator

@rodrigopaulino
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#101652
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success Good to go This PR can be forwarded
Projects
None yet
Milestone
No milestone
2 participants
@rodrigopaulino @liferay-continuous-integration