LPS-133614 Remove unnecessary condition for Fieldset when he is render #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-133614 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#4863 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-data-engine#527 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1251 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7841 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-data-engine#527 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - danvb112 > liferay-data-engine - PR#527 - 2021-06-14[10:33:37] Testray Importer:publish-testray-report#1088 |
|
ci:test:sf |
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-133614 1 Successful Jobs:For more details click here. |
danvb112
changed the title
|
ci:test:relevant |
danvb112
added
Frontend
Review Pending
|
Jenkins Build:test-portal-source-format#1145 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-data-engine#527 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#3439 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#1299 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-data-engine#527 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - danvb112 > liferay-data-engine - PR#527 - 2021-06-14[15:18:12] Testray Importer:publish-testray-report#3465 |
|
Just started reviewing :) |
guilhermedcamacho
added
In review
guilhermedcamacho
approved these changes
Jun 15, 2021
guilhermedcamacho
added
Good to go
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#103219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: https://issues.liferay.com/browse/LPS-133614
Resending #511