Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared Drive Migration Broke All Drive Links #1011

Open
plhnk opened this issue Jul 29, 2021 · 8 comments
Open

Shared Drive Migration Broke All Drive Links #1011

plhnk opened this issue Jul 29, 2021 · 8 comments
Assignees

Comments

@plhnk
Copy link
Member

plhnk commented Jul 29, 2021

Describe the bug
Any drive.google.com links that we were referencing broke when we changed from the standard drive to a shared drive (even though the subfolders all remained the same).

To Reproduce
Steps to reproduce the behavior:

  1. cmd + shift + f search in VS Code for https://drive.google.com
  2. Click on any of the links (except for the links at /blueprints/resources/logo-files
  3. See 404

Expected behavior
A drive folder should appear

Recommended steps to fix

  1. Perform the search in the "To Reproduce" section
  2. Go file-by-file, check the link to verify its broken
  3. Replace the broken link w/the correct one

Note — you'll need to make sure that the permissions to the folder you're sharing are set to "everyone at Liferay.com can comment".

cc @naoki-evan-hisamoto @abelhancock probably know where most of these folders are

leolohmann added a commit to leolohmann/liferay.design that referenced this issue Nov 17, 2021
Shared Drive migration broke various links that needed to be updated with the correct document link.

I performed the search, went through file-by-file checking each link available and replaced the broken ones with the correct document link.
@plhnk
Copy link
Member Author

plhnk commented Nov 17, 2021

thanks @leolohmann! great effort!

@drakonux can you take a look at #1046 — I left a bunch of comments and tagged you in a few, some of the docs linked in Lexicon weren't clear to me, just wanted to confirm w/you

@MiriamManso can you check my comment in the pr as well — in your article on research libraries some of the links were going to permissioned files in our internal drive

I'll be merging this PR first thing tomorrow morning (for me) — if you have changes that you'd like to have here, please either send them in a PR to Leo's fork, or you can comment in here and I can put them in.

If you can't look until later, or can't send info before I merge — that's not a big deal, can always do it later :)

@victorvalle
Copy link

@plhnk I've only checked 3 links in Lexicon pages and all of them are wrong. Is there something automatic that was not applied well? You guys did it manually? If so, I need to review everything form and send a PR that fixes everything manually.

@plhnk
Copy link
Member Author

plhnk commented Nov 17, 2021

@victorvalle no it was manual — it's not possible to do it automatically, it's just our best guess. This has raised another issue that I've pinged @drakonux about — I'm thinking that it will be better to address the underlying issue (i.e. why are we adding links to google docs, and now involving confluence) than put effort into fixing the links one by one as they have been broken for some time and no one has said anything.

@victorvalle
Copy link

Please, let me know the outcome and how I can help.

@leolohmann
Copy link
Contributor

@victorvalle I searched into our shared folder and linked to the document that had most similarities with the topic on each specific page.

@victorvalle
Copy link

GDrive Lexicon folder and Lexicon site structure are quite similar. Just following both trees many things should match. But in that case, I would do it. It will be far easy for me.

@plhnk
Copy link
Member Author

plhnk commented Nov 17, 2021

@victorvalle if its going to take more than 15 minutes to do it and send the PR to Leo's branch — do it, if not — IMHO its not worth it

plhnk pushed a commit that referenced this issue Nov 17, 2021
Shared Drive migration broke various links that needed to be updated with the correct document link.

I performed the search, went through file-by-file checking each link available and replaced the broken ones with the correct document link.
@plhnk
Copy link
Member Author

plhnk commented Nov 17, 2021

Note — leaving this issue open — if anyone is able to tackle this in the future, please check the PR reviews in #1046 for details from @victorvalle and @drakonux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants