Broken link update to PNG and SVG icons #1046

leolohmann · 2021-11-12T15:17:49Z

Updating the links from the Iconography page.

The error was caused by the change in Google Drive a few months ago when all the reference links were modified automatically .

Updating the links from the Iconography page. The error was caused by the change in Google Drive a few months ago when all the reference links were modified automatically .

netlify · 2021-11-12T15:17:52Z

👷 Deploy request for happy-jackson-1b6bb8 accepted.

🔨 Explore the source changes: 9d658e5

🔍 Inspect the deploy log: https://app.netlify.com/sites/happy-jackson-1b6bb8/deploys/619454361dbdd10008fbc022

plhnk

hey @leolohmann — taking a look at the deploy log, it looks like the blank lines you added are causing the component to break (and thus the page not to build).

Generally it's best to limit your changes to as minimal a place as possible — this helps prevent errors from pasting in things like invisible characters (line breaks, etc).

For example, your change in lines 29/31 is perfect, the only thing that was changed was between ".../folders/" and "?usp=sharing".

Please fix the PNG icon link and update your PR — thanks!

Previously, I wrongly added blank lines that caused the component to break. Now I cleaned and fixed the code the way it should be.

plhnk · 2021-11-16T22:59:05Z

great — thanks @leolohmann — looks like that passed, looking forward to getting the rest of the updates so we can close out #1011, #1014, and #1023!

Shared Drive migration broke various links that needed to be updated with the correct document link. I performed the search, went through file-by-file checking each link available and replaced the broken ones with the correct document link.

victorvalle · 2021-11-17T17:25:42Z

src/markdown/lexicon/core-components/alerts.md

@@ -3,7 +3,7 @@ title: 'Alerts'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/alert'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6076%3A101'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8sabC0yT0FuaUNwUXc?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1sRrlIXYnMAqyBk1n1QLDPO2sKNYKl7AUt7aJogYXhWs/edit?usp=sharing'


This is not ok. It points out to a document in Clay not in Lexicon and design documentation. Please find the right one.

victorvalle · 2021-11-17T17:27:02Z

src/markdown/lexicon/core-components/badges/index.mdx

@@ -3,7 +3,7 @@ title: 'Badges'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/badge.html'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6012%3A45959'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8saNzRRRDhUSlhRR0k?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1PNudTqmS1JCSJwMt_h2CA9QobplxIDfwF7tZsjUpavw/edit?usp=sharing'


This link points out to tables and not to badges. Wrong link, please check again

victorvalle · 2021-11-17T17:29:09Z

src/markdown/lexicon/core-components/cards/index.md

@@ -3,7 +3,7 @@ title: 'Cards'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/card.html'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6026%3A914'
-docLink: 'https://drive.google.com/drive/folders/0B7JYaGe4TecDbXlfTVBDandaTXM?usp=sharing'
+docLink: 'https://docs.google.com/document/d/13n2SseXDxuh4TbGJohRWVrXiXQ9NRsTz5Uyy6GE5VFc/edit?usp=sharing'


This links to lexicon-clay roadmap for 7.2 not to Cards documentation

victorvalle · 2021-11-17T17:37:08Z

src/markdown/articles/2021/comparative-historical-research/index.mdx

-Exhaustive research on heuristic evaluation from its inception would have taken years of dedication, time we did not have. Therefore, we made an incipient approach to the most relevant documentation to which we had access. We reviewed the contributions of [John D. Gould and Clayton Lewis](http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.84.8860&rep=rep1&type=pdf) (1985), [Ben Shneiderman](http://www.cs.umd.edu/~ben/goldenrules.html?utm_source=blog.intellyo&utm_medium=referral&utm_campaign=Heuristic%20Analysis%20UX%20in%20the%20design%20process&utm_content=text&utm_term=Eight%20Golden%20Rules%20of%20Interface%20Design) (1992), [Christian Bastien & Dominique Scapin](https://drive.google.com/file/d/1avCzLvuTd9NDKiQTFVnVa8k7TG465gz0/view?usp=sharing) (1992), [Jakob Nielsen](https://www.nngroup.com/articles/ten-usability-heuristics/) (1994), [Gerhardt-Powals]() (1996), [Weinschenk and Barker](https://measuringu.com/he-cw/) (2000), [Connell & Hammon](https://drive.google.com/file/d/1304NyggTs71onzixZrdaXldoB-WGEbR4/view?usp=sharing) (2000), and [Bruce Tognazzini’s](https://asktog.com/atc/principles-of-interaction-design/) (2003). 
-Then we compiled a list of almost [30 documents including articles](https://docs.google.com/spreadsheets/d/1ra2S8XahDR4LNGeUyknEbzOhwlLryzi8mEJON2TG8Z8/edit?usp=sharing), conferences and doctoral theses of the most recent approaches to the subject ([Granollers](https://drive.google.com/file/d/1ys6o9aFSQz4clVcClqd5Y5cSkqKxOYKe/view) (2018), [Suárez](https://drive.google.com/file/d/152B10nAVdlDm-S1fu0V8-2ChFmG1LP3Q/view) (2011); [Paz](https://drive.google.com/file/d/1f5iVwNNV1DdxtamLpDxpzwhPkeyjv_6p/view) (2018), [Murillo](https://drive.google.com/file/d/1j9x5YrYQ4o1O9glpCg-zEsNA46FMajBa/view) (2018), [Quiñones](https://drive.google.com/file/d/1AfVWu8SbHOUdOoT4imSVwVP4dD3VUpmm/view) (2018); [Kurosu](https://drive.google.com/file/d/1O1HF05-eOraIao9CV04BjPNBLcCO2O4t/view) (2018); [Cooper](https://drive.google.com/drive/u/0/search?q=heuristics) (2007)). 
+Exhaustive research on heuristic evaluation from its inception would have taken years of dedication, time we did not have. Therefore, we made an incipient approach to the most relevant documentation to which we had access. We reviewed the contributions of [John D. Gould and Clayton Lewis](http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.84.8860&rep=rep1&type=pdf) (1985), [Ben Shneiderman](http://www.cs.umd.edu/~ben/goldenrules.html?utm_source=blog.intellyo&utm_medium=referral&utm_campaign=Heuristic%20Analysis%20UX%20in%20the%20design%20process&utm_content=text&utm_term=Eight%20Golden%20Rules%20of%20Interface%20Design) (1992), [Christian Bastien & Dominique Scapin](https://hal.inria.fr/inria-00070012/document) (1992), [Jakob Nielsen](https://www.nngroup.com/articles/ten-usability-heuristics/) (1994), [Gerhardt-Powals]() (1996), [Weinschenk and Barker](https://measuringu.com/he-cw/) (2000), [Connell & Hammon](http://www0.cs.ucl.ac.uk/staff/i.connell/DocsPDF/PrinciplesSet.pdf) (2000), and [Bruce Tognazzini’s](https://asktog.com/atc/principles-of-interaction-design/) (2003). 
+Then we compiled a list of almost [30 documents including articles](https://docs.google.com/spreadsheets/d/1ra2S8XahDR4LNGeUyknEbzOhwlLryzi8mEJON2TG8Z8/edit?usp=sharing), conferences and doctoral theses of the most recent approaches to the subject ([Granollers](https://drive.google.com/file/d/1ys6o9aFSQz4clVcClqd5Y5cSkqKxOYKe/view) (2018), [Suárez](https://www.researchgate.net/publication/233856298_Sirius_A_heuristic-based_framework_for_measuring_web_usability_adapted_to_the_type_of_website) (2011); [Paz](https://drive.google.com/file/d/1f5iVwNNV1DdxtamLpDxpzwhPkeyjv_6p/view?usp=sharing) (2018), [Murillo](https://drive.google.com/file/d/1j9x5YrYQ4o1O9glpCg-zEsNA46FMajBa/view?usp=sharing) (2018), [Quiñones](https://drive.google.com/file/d/1_zy3CWCM8fDeN20yE6e1QKisXe3RGp0i/view?usp=sharing) (2018); [Kurosu](https://www.semanticscholar.org/paper/Categorical-inspection-method-structured-heuristic-Kurosu-Matsuura/354417d28806d1f86223842817e9fb17435caa97) (2018); [Cooper](https://docs.google.com/document/d/1n2Kgv7nPcmf77t8g6EudafXNVo9eMjJBt6pR1GqD3PE/edit?usp=sharing) (2007)). 


Links reviewed and working well @MiriamManso

plhnk

thanks @leolohmann

plhnk · 2021-11-17T05:50:19Z

src/markdown/articles/2021/comparative-historical-research/index.mdx

-Exhaustive research on heuristic evaluation from its inception would have taken years of dedication, time we did not have. Therefore, we made an incipient approach to the most relevant documentation to which we had access. We reviewed the contributions of [John D. Gould and Clayton Lewis](http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.84.8860&rep=rep1&type=pdf) (1985), [Ben Shneiderman](http://www.cs.umd.edu/~ben/goldenrules.html?utm_source=blog.intellyo&utm_medium=referral&utm_campaign=Heuristic%20Analysis%20UX%20in%20the%20design%20process&utm_content=text&utm_term=Eight%20Golden%20Rules%20of%20Interface%20Design) (1992), [Christian Bastien & Dominique Scapin](https://drive.google.com/file/d/1avCzLvuTd9NDKiQTFVnVa8k7TG465gz0/view?usp=sharing) (1992), [Jakob Nielsen](https://www.nngroup.com/articles/ten-usability-heuristics/) (1994), [Gerhardt-Powals]() (1996), [Weinschenk and Barker](https://measuringu.com/he-cw/) (2000), [Connell & Hammon](https://drive.google.com/file/d/1304NyggTs71onzixZrdaXldoB-WGEbR4/view?usp=sharing) (2000), and [Bruce Tognazzini’s](https://asktog.com/atc/principles-of-interaction-design/) (2003). 
-Then we compiled a list of almost [30 documents including articles](https://docs.google.com/spreadsheets/d/1ra2S8XahDR4LNGeUyknEbzOhwlLryzi8mEJON2TG8Z8/edit?usp=sharing), conferences and doctoral theses of the most recent approaches to the subject ([Granollers](https://drive.google.com/file/d/1ys6o9aFSQz4clVcClqd5Y5cSkqKxOYKe/view) (2018), [Suárez](https://drive.google.com/file/d/152B10nAVdlDm-S1fu0V8-2ChFmG1LP3Q/view) (2011); [Paz](https://drive.google.com/file/d/1f5iVwNNV1DdxtamLpDxpzwhPkeyjv_6p/view) (2018), [Murillo](https://drive.google.com/file/d/1j9x5YrYQ4o1O9glpCg-zEsNA46FMajBa/view) (2018), [Quiñones](https://drive.google.com/file/d/1AfVWu8SbHOUdOoT4imSVwVP4dD3VUpmm/view) (2018); [Kurosu](https://drive.google.com/file/d/1O1HF05-eOraIao9CV04BjPNBLcCO2O4t/view) (2018); [Cooper](https://drive.google.com/drive/u/0/search?q=heuristics) (2007)). 
+Exhaustive research on heuristic evaluation from its inception would have taken years of dedication, time we did not have. Therefore, we made an incipient approach to the most relevant documentation to which we had access. We reviewed the contributions of [John D. Gould and Clayton Lewis](http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.84.8860&rep=rep1&type=pdf) (1985), [Ben Shneiderman](http://www.cs.umd.edu/~ben/goldenrules.html?utm_source=blog.intellyo&utm_medium=referral&utm_campaign=Heuristic%20Analysis%20UX%20in%20the%20design%20process&utm_content=text&utm_term=Eight%20Golden%20Rules%20of%20Interface%20Design) (1992), [Christian Bastien & Dominique Scapin](https://hal.inria.fr/inria-00070012/document) (1992), [Jakob Nielsen](https://www.nngroup.com/articles/ten-usability-heuristics/) (1994), [Gerhardt-Powals]() (1996), [Weinschenk and Barker](https://measuringu.com/he-cw/) (2000), [Connell & Hammon](http://www0.cs.ucl.ac.uk/staff/i.connell/DocsPDF/PrinciplesSet.pdf) (2000), and [Bruce Tognazzini’s](https://asktog.com/atc/principles-of-interaction-design/) (2003). 
+Then we compiled a list of almost [30 documents including articles](https://docs.google.com/spreadsheets/d/1ra2S8XahDR4LNGeUyknEbzOhwlLryzi8mEJON2TG8Z8/edit?usp=sharing), conferences and doctoral theses of the most recent approaches to the subject ([Granollers](https://drive.google.com/file/d/1ys6o9aFSQz4clVcClqd5Y5cSkqKxOYKe/view) (2018), [Suárez](https://www.researchgate.net/publication/233856298_Sirius_A_heuristic-based_framework_for_measuring_web_usability_adapted_to_the_type_of_website) (2011); [Paz](https://drive.google.com/file/d/1f5iVwNNV1DdxtamLpDxpzwhPkeyjv_6p/view?usp=sharing) (2018), [Murillo](https://drive.google.com/file/d/1j9x5YrYQ4o1O9glpCg-zEsNA46FMajBa/view?usp=sharing) (2018), [Quiñones](https://drive.google.com/file/d/1_zy3CWCM8fDeN20yE6e1QKisXe3RGp0i/view?usp=sharing) (2018); [Kurosu](https://www.semanticscholar.org/paper/Categorical-inspection-method-structured-heuristic-Kurosu-Matsuura/354417d28806d1f86223842817e9fb17435caa97) (2018); [Cooper](https://docs.google.com/document/d/1n2Kgv7nPcmf77t8g6EudafXNVo9eMjJBt6pR1GqD3PE/edit?usp=sharing) (2007)). 


thanks for checking these @leolohmann!

@MiriamManso please double-check, it looks like some of these links won't work unless a user is signed into our Drive (which...most people won't be ;)

Please either change the file permissions (so anyone can see without being signed into a Google account) or host them directly in our repo.

Also — I'm assuming that these files are OK to share publicly...right? :D

plhnk · 2021-11-17T05:53:06Z

src/markdown/lexicon/core-components/alerts.md

@@ -3,7 +3,7 @@ title: 'Alerts'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/alert'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6076%3A101'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8sabC0yT0FuaUNwUXc?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1sRrlIXYnMAqyBk1n1QLDPO2sKNYKl7AUt7aJogYXhWs/edit?usp=sharing'


@drakonux can you verify this is the correct link for this page?

plhnk · 2021-11-17T05:54:32Z

src/markdown/lexicon/core-components/badges/index.mdx

@@ -3,7 +3,7 @@ title: 'Badges'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/badge.html'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6012%3A45959'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8saNzRRRDhUSlhRR0k?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1PNudTqmS1JCSJwMt_h2CA9QobplxIDfwF7tZsjUpavw/edit?usp=sharing'


@drakonux is this the correct link?

plhnk · 2021-11-17T05:55:12Z

src/markdown/lexicon/core-components/cards/index.md

@@ -3,7 +3,7 @@ title: 'Cards'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/card.html'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6026%3A914'
-docLink: 'https://drive.google.com/drive/folders/0B7JYaGe4TecDbXlfTVBDandaTXM?usp=sharing'
+docLink: 'https://docs.google.com/document/d/13n2SseXDxuh4TbGJohRWVrXiXQ9NRsTz5Uyy6GE5VFc/edit?usp=sharing'


@drakonux is this the correct link?

plhnk · 2021-11-17T05:55:42Z

src/markdown/lexicon/core-components/charts/chart-doughnut.md

@@ -3,7 +3,7 @@ title: 'Donut Chart'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/charts.html'
 figmaLink: 'https://www.figma.com/file/CZyK1h5vmNBAm9Lgth89zpC4/lexicon-charts?node-id=254%3A649'
-docLink: 'https://drive.google.com/drive/folders/13BbAbwfF7RvRGfTBlB_--vX5Oqn4jZq8?usp=sharing'
+docLink: 'https://docs.google.com/spreadsheets/d/1DNV-YGxH69i7UGEUcqMBWOxmaeX5bSDizrA9E-91VAQ/edit?usp=sharing'


@drakonux is this the correct link?

plhnk · 2021-11-17T05:57:51Z

src/markdown/lexicon/core-components/dual-listbox.md

@@ -3,7 +3,7 @@ title: 'Dual Listbox'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/dual-list_box.html'
 figmaLink: 'https://www.figma.com/file/02DVhuHVTDbzaMjNM7IUKWp0/lexicon?node-id=6020%3A9595'
-docLink: 'https://drive.google.com/drive/folders/1AFySLLYLN0Kkdl1_MCc6EtDbz6wzgOfW?usp=sharing'
+docLink: 'https://docs.google.com/document/d/13n2SseXDxuh4TbGJohRWVrXiXQ9NRsTz5Uyy6GE5VFc/edit?usp=sharing'


this links to "General UX Improvement proposals for DXP 7.2" — is this intended @drakonux ?

plhnk · 2021-11-17T06:00:26Z

src/markdown/lexicon/core-components/link.md

@@ -2,7 +2,7 @@
 title: 'Link'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/link.html'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8saZVA0emlsSTl3Z0U?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1M-zY163zfOyCbnfzawglo6laugDbcmpP6LEZHX-eD_w/edit?usp=sharing'


@drakonux is this intended to ilnk to "Links to Mockups and Assets"?

plhnk · 2021-11-17T06:01:45Z

src/markdown/lexicon/core-components/slider.md

@@ -2,7 +2,7 @@
 title: 'Slider'
 titleLabel: 'Clay'
 titleLabelLink: 'https://clayui.com/docs/components/slider'
-docLink: 'https://drive.google.com/drive/folders/1AYP4PlxDino-cr27uYXhXht4fcvTSYIh?usp=sharing'
+docLink: 'https://docs.google.com/spreadsheets/d/1DNV-YGxH69i7UGEUcqMBWOxmaeX5bSDizrA9E-91VAQ/edit?usp=sharing'


@drakonux is this intended to link to the patterns needed and patterns improved page?

plhnk · 2021-11-17T06:04:04Z

src/markdown/lexicon/foundations/layout/layout-full.md

@@ -1,7 +1,7 @@
 ---
 title: 'Full Box'
 description: "The Full Box layout adapts to always be 100% of the container's width, occupying twelve columns of the grid."
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8saZXMtb2hzRy0yYW8?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1z22aVdWm0j_nsCgnNtLpmTzhUJwktXCvrGSMpJbNSbQ/edit?usp=sharing'


@drakonux is this supposed to link to the Modals documentation?

plhnk · 2021-11-17T06:04:31Z

src/markdown/lexicon/foundations/layout/layout-sidebar.md

@@ -1,7 +1,7 @@
 ---
 title: 'Sidebar + Box'
 description: 'A specific layout used when a left sidebar requires a vertical navigation.'
-docLink: 'https://drive.google.com/drive/folders/0B-KKkYVQA8saZXMtb2hzRy0yYW8?usp=sharing'
+docLink: 'https://docs.google.com/document/d/1z22aVdWm0j_nsCgnNtLpmTzhUJwktXCvrGSMpJbNSbQ/edit?usp=sharing'


@drakonux this also links to the modals doc — is this intended?

Broken link update to PNG and SVG icons

346f021

Updating the links from the Iconography page. The error was caused by the change in Google Drive a few months ago when all the reference links were modified automatically .

plhnk requested changes Nov 12, 2021

View reviewed changes

Fix code format in iconography.mdx

b52cbfb

Previously, I wrongly added blank lines that caused the component to break. Now I cleaned and fixed the code the way it should be.

This was referenced Nov 17, 2021

Resource thumbnails link is broken #1023

Closed

Links are broken on blueprints #1014

Closed

Shared Drive Migration Broke All Drive Links #1011

Open

victorvalle reviewed Nov 17, 2021

View reviewed changes

plhnk approved these changes Nov 17, 2021

View reviewed changes

plhnk merged commit 4288cfc into liferay-design:master Nov 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Broken link update to PNG and SVG icons #1046

Broken link update to PNG and SVG icons #1046

leolohmann commented Nov 12, 2021

netlify bot commented Nov 12, 2021 •

edited

Loading

plhnk left a comment

plhnk commented Nov 16, 2021

victorvalle Nov 17, 2021

victorvalle Nov 17, 2021

victorvalle Nov 17, 2021

victorvalle Nov 17, 2021

plhnk left a comment

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

plhnk Nov 17, 2021

Broken link update to PNG and SVG icons #1046

Broken link update to PNG and SVG icons #1046

Conversation

leolohmann commented Nov 12, 2021

netlify bot commented Nov 12, 2021 • edited Loading

plhnk left a comment

Choose a reason for hiding this comment

plhnk commented Nov 16, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

plhnk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented Nov 12, 2021 •

edited

Loading