Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-172113 Asset Publisher configuration uses inconsistent values for select more than one selectors #10955

Closed
wants to merge 3 commits into from
Closed

LPS-172113 Asset Publisher configuration uses inconsistent values for select more than one selectors #10955

wants to merge 3 commits into from

Conversation

balazssk
Copy link
Collaborator

Hi Team,
Can you please review this?

Motivation

https://issues.liferay.com/browse/LPS-172113
AssetPublisherExportImportPortletPreferencesProcessor can't process anyClassTypeDLFileEntryAssetRendererFactory, anyClassTypeJournalArticleAssetRendererFactory and anyAssetType preferences, because "false" value can't be set on them.

Proposed Solution

Revert the "select-more-than-one" values to "false" like how "any" was reverted to "true"

Steps to Verify

  1. In the Global site, create 3 document types (I've called them TYPE_A, TYPE_B and TYPE_C)
  2. Create a new site : Alpha
  3. In Alpha, create 3 documents using the 3 types we have created
  4. In Alpha, create a new content page and add the Asset Publisher Widget
  5. Configure the Asset Publisher Widget:
    1. Asset Selection: Dynamic
    2. Source - Asset Type: Document
    3. Source - Document Type: Select More Than One...
    4. Source - Selected: TYPE_A and TYPE_B (we don't include TYPE_C)
  6. The Asset Publisher displays 2 out of the 3 documents we have created, this is expected.
  7. On the Alpha site, go to Publishing - Export and make a complete export of the site.
  8. Create a new site : Beta
  9. On the Beta site, go to Publishing - Import and import the Alpha site's lar

Expected behaviour: The Beta site page displays the 2 filtered documents.
The configuration of the Asset Publisher on the Beta page is the same as on Alpha.

Actual behaviour: The Beta site page displays the 2 filtered documents (the one of TYPE_C is not displayed, as expected).
However, if you go to the Asset Publisher configuration, it's wrong because you have;

  1. Asset Selection: Dynamic
  2. Source - Asset Type: Document
  3. Source - Document Type: Any
  4. The filter on document type TYPE_A and TYPE_B is lost.

Cheers,
Balázs

@liferay-echo
Copy link
Owner

Thank you for submitting this PR. 👏

Make sure it follows the Echo Pull Request Template if you haven't already done so.

Learn more about it here.

@liferay-echo liferay-echo added 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. labels Jan 30, 2023
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@balazssk
Copy link
Collaborator Author

ci:test:sf

@balazssk
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 324a611760a954902a602c3ac0737f1a9e9a42c4

Sender Branch:

Branch Name: LPS-172113
Branch GIT ID: 216d4d0d7429ec991566411fa4b92b8bb8345915

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@victorg1991 victorg1991 removed the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jan 31, 2023
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 28 out of 28 jobs passed

✔️ ci:test:relevant - 122 out of 129 jobs passed in 1 hour 37 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 324a611760a954902a602c3ac0737f1a9e9a42c4

Upstream Comparison:

Branch GIT ID: 3073d0a3d8084b7d42545a2f024ca00f6295bfbd
Jenkins Build URL: EE Development Acceptance (master) - 4242 - 2023-01-30[20:13:53]

ci:test:stable - 28 out of 28 jobs PASSED
28 Successful Jobs:
    ci:test:relevant - 121 out of 129 jobs PASSED

    8 Failed Jobs:

    121 Successful Jobs:
      For more details click here.

      This pull contains no unique failures.

      Failures in common with acceptance upstream results at 3073d0a:
      6. ...

      @liferay-continuous-integration
      Copy link
      Collaborator

      @ealonso
      Copy link
      Collaborator

      ealonso commented Jan 31, 2023

      ci:forward

      @liferay-continuous-integration
      Copy link
      Collaborator

      CI is automatically triggering the following test suites:

      •     ci:test:relevant
      •     ci:test:sf

      The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

      •     ci:test:relevant
      •     ci:test:sf
      •     ci:test:stable

      @liferay-continuous-integration
      Copy link
      Collaborator

      Skipping previously passed test suites:
      ci:test:relevant
      ci:test:sf

      @ealonso ealonso added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. labels Jan 31, 2023
      @liferay-continuous-integration
      Copy link
      Collaborator

      All required test suite(s) passed.
      Forwarding pull request to brianchandotcom.
      Console

      Closed
      @liferay-continuous-integration
      Copy link
      Collaborator

      Pull request has been successfully forwarded to brianchandotcom#129449
      Console

      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Reviewers
      No reviews
      Assignees
      No one assigned
      Labels
      ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
      Projects
      None yet
      Milestone
      No milestone
      5 participants
      @balazssk @liferay-echo @liferay-continuous-integration @ealonso @victorg1991