LPS-116693 baseline #2282

ealonso · 2020-09-10T22:26:53Z

forward

…s applied to the columns

…wn vulnerability

…oes not exist

<aui:input name="commerceInventoryWarehouseId" type="hidden" /> <aui:input name="commerceInventoryWarehouseItemId" type="hidden" /> <aui:input name="sku" type="hidden" value="<%= cpInstance.getSku() %>" /> <aui:input name="quantity" type="hidden" /> <aui:input name="mvccVersion" type="hidden" />

…terions on asset publisher item selector

…ow or not show the different tabs

…item selector views

…e I can administer for asset publisher and doesn't include recent sites and my sites

ealonso · 2020-09-10T22:26:56Z

ci:forward

Sent from GH.

liferay-continuous-integration · 2020-09-10T22:27:01Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

liferay-continuous-integration · 2020-09-10T22:27:02Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-09-10T22:31:16Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a6542fe6c2e05052e83df0ba1aabd5e4b8aa1e36

Sender Branch:

Branch Name: LPS-106461
Branch GIT ID: a71bc3448ea4904e5624a24a7e4133dcb72221f0

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-09-10T22:47:07Z

Jenkins Build:test-portal-source-format#3721
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2282
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - ealonso > liferay-echo - PR#2282 - 2020-09-10[15:27:25]
Spira Jenkins Build:publish-spira-report#5061

liferay-continuous-integration · 2020-09-11T00:48:42Z

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 89 out of 92 jobs passed in 2 hours 21 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 049adaa8060bfec3681b787a5186107b630d7cef

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 35186087dfbc07539501385ca053c52db3343bb7

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 89 out of 92 jobs PASSED

3 Failed Jobs:

89 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
27 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #432732
  1. LocalFile.AssetPublisherShowFullContent#ConfigureAPPortletScopeMultipleSites - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at a6542fe:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

2705 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=4,label_exp=!master #437554

DLFileEntryTypeServiceTest.testUpdateFileEntryTypeWithEmptyDDMForm

com.liferay.dynamic.data.mapping.validator.DDMFormValidationException$MustSetValidType: Invalid type set for field type Text
	at com.liferay.dynamic.data.mapping.validator.internal.DDMFormValidatorImpl.validateDDMFormFieldType(DDMFormValidatorImpl.java:299)
	at com.liferay.dynamic.data.mapping.validator.internal.DDMFormValidatorImpl.validateDDMFormFields(DDMFormValidatorImpl.java:258)
	at com.liferay.dynamic.data.mapping.validator.internal.DDMFormValidatorImpl.validate(DDMFormValidatorImpl.java:97)
	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.validate(DDMStructureLocalServiceImpl.java:1913)
	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.validate(DDMStructureLocalServiceImpl.java:1963)
	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.validate(DDMStructureLocalServiceImpl.java:1951)
	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.addStructure(DDMStructureLocalServiceImpl.java:169)
	at com.liferay.dynamic.data.mapping.service.impl.DDMStructureLocalServiceImpl.addStructure(DDMStructureLocalServiceImpl.java:314)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.portal.spring.aop.AopMethodInvocationImpl....

liferay-continuous-integration · 2020-09-11T01:00:40Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6532
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2282
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ealonso > liferay-echo - PR#2282 - 2020-09-10[15:27:19]
Spira Jenkins Build:publish-spira-report#8926

Tim-Cao · 2020-09-11T01:00:42Z

Just start reviewing

Tim-Cao · 2020-09-11T01:40:33Z

Hi @ealonso, your changes cause the following regression issue
Add a widget page
Add an Asset Publisher to page
Click the ellipsis button on the topper of Asset Publisher
Configuration > Setup > Asset Selection
Expand Scope
Click Select
Other Site or Asset Library...

Expected Results:

Actual Results:

ealonso · 2020-09-11T06:50:46Z

Hey @Tim-Cao

The second screenshot is the expected behaviour, since for some reason the Lima Team change the behaviour in our component. I made some changes to keep the behaviour that we have in 7.2, and it is the second screenshot.

Could you please take a look and fix the poshi tests?

Regards,
Eudaldo.

Tim-Cao · 2020-09-11T07:22:49Z

ci:close

Tim-Cao · 2020-09-11T07:43:59Z

See #2289

brianchandotcom and others added 30 commits September 10, 2020 11:01

LPS-119867 rename property, use 1.0.3

53a7b8d

LRQA-60172 | Fix for the first 2 tests

f81da0b

LRQA-60172 | master

6bb4e7c

LRQA-61179 | master

69a8924

LRQA-60364 | master

84f0208

LPS-120707 Do not add ml-0 nor mr-0 to the row, otherwise a padding i…

68da7e4

…s applied to the columns

LPS-120395 Add tooltip to subscribe button

71ce80c

LPS-120395 Add tooltip to delete question button

436a3e6

LPS-120712 Update Headless breaking changes during 7.3 development

73e8dcc

LPS-120671 Update hibernate-validator dependency version to avoid kno…

1f88c67

…wn vulnerability

COMMERCE-4761 delete shipment action modal fixed

a95d667

COMMERCE-4772 Get channel from commerce context

dbfde27

COMMERCE-4747 BOM deps clean up, minor refactor, dismissed redux

8881b44

LPS-102001 generate

3b76945

LPS-102001 test for extensionContextResolver

226782e

LPS-102001 do not fail in new fields

a9fa86d

LPS-102001 move test

87ee051

LPS-102001 rename

40981d4

LPS-102001 prep next

475c029

LPS-102001 prep next

781b2e9

LPS-102001 prep next

e3e5604

LPS-102001 regen

0628920

artifact:ignore portal-impl 5.14.9 prep next

c5a83a1

artifact:ignore portal-impl 5.14.9 releng

e1014e9

artifact:ignore portal-kernel 9.2.3 prep next

2e270eb

artifact:ignore portal-kernel 9.2.3 releng

56847cd

artifact:ignore portal-web 4.0.74 prep next

95cd54c

artifact:ignore portal-web 4.0.74 releng

48ddee1

build.gradle auto SF

9e96814

artifact:ignore account-lang 1.0.8 change log

9f20fbf

Igor Beslic and others added 8 commits September 10, 2020 12:30

COMMERCE-4769 warehouse-web - FIX Bug - avoid NPE if inventory item d…

63e041e

…oes not exist

LPS-106461 We should use GroupItemSelectorCriterion to show those cri…

aaa9488

…terions on asset publisher item selector

LPS-116693 Make it consistent with other classes

f5c5b12

LPS-116693 Adds new methods to GroupItemSelectorCriterion to allow sh…

b702f48

…ow or not show the different tabs

LPS-116693 Take into account the new methods to show or not show the …

d95662d

…item selector views

LPS-116693 Include child groups, parent groups, layout groups and sit…

c4c16da

…e I can administer for asset publisher and doesn't include recent sites and my sites

LPS-116693 baseline

a71bc34

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Sep 10, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Sep 11, 2020

liferay-continuous-integration closed this Sep 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-116693 baseline #2282

LPS-116693 baseline #2282

ealonso commented Sep 10, 2020

ealonso commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 11, 2020

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

liferay-continuous-integration commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

ealonso commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

LPS-116693 baseline #2282

LPS-116693 baseline #2282

Conversation

ealonso commented Sep 10, 2020

ealonso commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 10, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Sep 10, 2020

liferay-continuous-integration commented Sep 11, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

❌ ci:test:relevant - 89 out of 92 jobs passed in 2 hours 21 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8

Job Results:

liferay-continuous-integration commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

ealonso commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020

Tim-Cao commented Sep 11, 2020