New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS] LPS-121823 Inconsistent Web Content with Image field type when referencing removed or renamed Document #2597
Conversation
…age type Recover the document before print his information on the Image field type to check if this information has been updated. Solution based on LPS-92263 that resolved the same problem to the Document and Media field type.
ci:test:sf |
ci:test:relevant |
Just started reviewing :) |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-121823 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#3218 |
ci:test:relevant |
Jenkins Build:test-portal-acceptance-pullrequest(master)#7359 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6045 |
ci:test:relevant |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
Skipping previously passed test suites: |
Jenkins Build:test-portal-acceptance-pullrequest(master)#7157 |
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#94964 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#6403 |
Hi @liferay-echo,
This solution resolves the same problem that LPS-92263 did with the Document and Media field type but with the Image field type. When you remove or rename a Document, the Web Contents referencing them with Image field type aren't updated. In the edit Web Content view, the old name is visualized. When the image is removed, no warning message is shown in the edit Web Content view.
In JournalConverterImpl.java class, I reuse the same method modified in LPS-92263. In the template "image.ftl" the solution the same too.