[TS] LPS-123406 #2884

ChrisKian · 2020-11-12T19:40:10Z

https://issues.liferay.com/browse/LPS-123406

Limiting the amount of "recent" groups we retrieve from the DB will give us a performance boost in situations where there are hundred of entries. This PR also includes other minor performance improvements.

@Preston-Crary, I'm sending this PR directly to the echo team, since it mostly deals with business logic and the performance boosts are more obvious. Please let me know if you have questions/concerns with the solution though.

… Following LPS-114381, the magic number seems to be 8.

…event redundant sublist or return early.

…is the magic number according to LPS-114381.

liferay-continuous-integration · 2020-11-12T19:40:20Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

Preston-Crary · 2020-11-12T20:21:38Z

@ChrisKian does this need an upgrade or will it fix itself by the user just navigating around?

ChrisKian · 2020-11-12T20:35:51Z

@Preston-Crary, the issue will resolve itself as soon as the RecentGroupManager.addRecentGroup() method is called. In my testing, this happens upon portal login and page navigation.

jkappler · 2020-11-13T11:44:46Z

ci:test:relevant

liferay-continuous-integration · 2020-11-13T13:40:16Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 24 jobs passed in 1 hour 37 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 06e707df4454e36051558b8c5deaf7600497f9ab

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 20 out of 24 jobs PASSED

4 Failed Jobs:

20 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

9 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=5,label_exp=!master #311040

     [exec] * What went wrong:
     [exec] Could not resolve all artifacts for configuration 'classpath'.
     [exec] > Could not resolve xalan:xalan:2.7.2.
     [exec]   Required by:
     [exec]       unspecified:unspecified:unspecified
     [exec]    > Could not resolve xalan:xalan:2.7.2.
     [exec]       > Could not parse POM https://repository-cdn.liferay.com/nexus/content/groups/public/xalan/xalan/2.7.2/xalan-2.7.2.pom
     [exec]          > Could not resolve org.apache:apache:4.
     [exec]             > Could not resolve org.apache:apache:4.
     [exec]                > Could not get resource 'https://repository-cdn.liferay.com/nexus/content/groups/public/org/apache/apache/4/apache-4.pom'.
     [exec]                   > Could not HEAD 'https://repository-cdn.liferay.com/nexus/content/groups/public/org/apache/apache/4/apache-4.pom'.
     [exec]                      > repository-cdn.liferay.com:443 failed to respond
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration$ArtifactResolveException: Could not resolve all artifacts for configuration 'classpath'.
     [exec] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.rethrowFailure(DefaultConfiguration.java:1276)
     [exec] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration.access$1700(DefaultConfiguration.java:142)
     [exec] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$ConfigurationArtifactCollection.ensureResolved(DefaultConfiguration.java:1838)
     [exec] 	at org.gradle.api.internal.artifacts.configurations.DefaultConfiguration$ConfigurationArtifactCollection.getArtifacts(DefaultConfiguration.java:1804)
     [exec] 	at org.gradle.composite.internal.CompositeBuildClassPathInitializer.execute(CompositeBuildClassPathInitializer.java:45)
     [exec] 	at org.gradle.composite.internal.CompositeBuildClassPathInitializer.execute(CompositeBuildClassPathInitializer.java:32)
     [exec] 	at org.gradle.api.internal.initialization.DefaultScriptClassPathResolver.resolveClassPath(DefaultScriptClassPathResolver.java:37)
     [exec] 	at org.gradle.api.internal.initialization.DefaultScriptHandler.getScriptClassPath(DefaultScriptHandler.java:87)

Failures in common with acceptance upstream results at 06e707d:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
544 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #469099
  1. PortalLogAssertorTest.testScanXMLLog

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0

Job Results:

184 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1,label_exp=!master #455956

ProjectTemplatesRESTBuilderTest.testCompareRESTBuilderPluginVersions

org.gradle.testkit.runner.UnexpectedBuildFailure: Unexpected build execution failure in /tmp/junit2366199131760606157/gradleWorkspacetest-workspace/test-workspace with arguments [clean, --debug, :modules:sample:sample-impl:dependencies]
Output:

12:58:29.239 [INFO] [org.gradle.launcher.daemon.server.exec.LogToClient] The client will now receive all logging from the daemon (pid: 18589). The daemon log file: /tmp/.gradle-test-kit-root/test-kit-daemon/5.6.4/daemon-18589.out.log

12:58:29.241 [INFO] [org.gradle.launcher.daemon.server.exec.LogAndCheckHealth] Starting build in new daemon [memory: 477.6 MB]

12:58:29.242 [INFO] [org.gradle.launcher.daemon.server.exec.ForwardClientInput] Closing daemon's stdin at end of input.

12:58:29.242 [INFO] [org.gradle.launcher.daemon.server.exec.ForwardClientInput] The daemon will no longer process any standard input.

12:58:29.246 [DEBUG] [org.gradle.launcher.daemon.server.exec.ExecuteBuild] The daemon has started executing the build.

12:58:29.247 [DEBUG] [org.gradle.launcher.daemon.server.exec.ExecuteBuild] Executing build with daemon context: DefaultDaemonContext[uid=30f0f8a1-3286-45d5-b075-e94130c938f6,javaHome=/opt/java/jdk1.8.0_121-x64,daemonRegistryDir=/tmp/.gradle-test-kit-root/test-kit-daemon,pid=18589,idleTimeout=120000,priority=NORMAL,daemonOpts=-XX:MaxMetaspaceSize=256m,-XX:+HeapDumpOnOutOfMemoryError,-Xms256m,-Xmx512m,-Dfile.encoding=UTF-8,-Duser.country=US,-Duser.language=en,-Duser.variant]

12:58:29.342 [INFO] [org.gradle.interna...

liferay-continuous-integration · 2020-11-13T14:09:57Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4945
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2884
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ChrisKian > liferay-echo - PR#2884 - 2020-11-13[04:01:09]
Spira Jenkins Build:publish-spira-report#13631

jkappler · 2020-11-16T16:56:25Z

ci:test:relevant

liferay-continuous-integration · 2020-11-16T20:16:44Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 18 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c74cbb3487428c54ae2122c205af3c954e0e01a3

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 24 jobs PASSED

2 Failed Jobs:

22 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 58c93cc:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

544 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1,label_exp=!master #370915

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to render content of fragment entry 90:null
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2020-11-16T20:24:18Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7426
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2884
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - ChrisKian > liferay-echo - PR#2884 - 2020-11-16[08:56:36]
Spira Jenkins Build:publish-spira-report#7275

jkappler · 2020-11-17T14:22:15Z

Just started reviewing :)

jkappler · 2020-11-17T14:29:21Z

ci:forward

liferay-continuous-integration · 2020-11-17T14:29:25Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-11-17T14:29:29Z

Skipping previously passed test suites:
ci:test:relevant

liferay-continuous-integration · 2020-11-17T14:33:06Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2dbfb0227526dca4eb3f9e51a137cc31d7da3f70

Sender Branch:

Branch Name: LPS-123406
Branch GIT ID: 8bf412deb8b43c49d2531e82bca1c96aa1f0aa40

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-11-17T14:33:18Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-11-17T14:33:41Z

Pull request has been successfully forwarded to brianchandotcom#96002

liferay-continuous-integration · 2020-11-17T14:39:04Z

Jenkins Build:test-portal-source-format#3673
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2884
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - ChrisKian > liferay-echo - PR#2884 - 2020-11-17[06:29:39]
Spira Jenkins Build:publish-spira-report#8471

ChrisKian added 3 commits November 12, 2020 10:38

LPS-123406 Set a limit to how many recent groups we retrieve at once.…

b2e2be5

… Following LPS-114381, the magic number seems to be 8.

LPS-123406 SF, modify logic surrounding recent groups retreival to pr…

9252c2b

…event redundant sublist or return early.

LPS-123406 Allow number of recent groups to be configurable, again 8 …

8bf412d

…is the magic number according to LPS-114381.

ChrisKian mentioned this pull request Nov 12, 2020

LPS-123199 Preston-Crary/liferay-portal#1244

Closed

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Nov 13, 2020

victorg1991 added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Nov 16, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Nov 16, 2020

jkappler self-assigned this Nov 17, 2020

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Nov 17, 2020

liferay-continuous-integration mentioned this pull request Nov 17, 2020

[TS] LPS-123406 brianchandotcom/liferay-portal#96002

Closed

liferay-continuous-integration closed this Nov 17, 2020

[TS] LPS-123406 #2884

[TS] LPS-123406 #2884

Conversation

ChrisKian commented Nov 12, 2020

liferay-continuous-integration commented Nov 12, 2020

Preston-Crary commented Nov 12, 2020

ChrisKian commented Nov 12, 2020

jkappler commented Nov 13, 2020

liferay-continuous-integration commented Nov 13, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 24 jobs passed in 1 hour 37 minutes

Base Branch:

Copied in Private Modules Branch:

4 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-unit-project-templates-jdk8/0

Job Results:

liferay-continuous-integration commented Nov 13, 2020

jkappler commented Nov 16, 2020

liferay-continuous-integration commented Nov 16, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 18 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Nov 16, 2020

jkappler commented Nov 17, 2020

jkappler commented Nov 17, 2020

liferay-continuous-integration commented Nov 17, 2020

liferay-continuous-integration commented Nov 17, 2020

liferay-continuous-integration commented Nov 17, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Nov 17, 2020

liferay-continuous-integration commented Nov 17, 2020

liferay-continuous-integration commented Nov 17, 2020