Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-123673 Create specific url for "Save and Add new One" Action instead of relying on currentURL which doesn't work in cases like edit #2941

Closed
wants to merge 1 commit into from
Closed

LPS-123673 Create specific url for "Save and Add new One" Action instead of relying on currentURL which doesn't work in cases like edit #2941

wants to merge 1 commit into from

Conversation

victorg1991
Copy link
Collaborator

No description provided.

@victorg1991
LPS-123673 Create specific url for "Save and Add new One" Action inst…
494eee9 
…ead of relying on currentURL which doesn't work in cases like edit
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@victorg1991
Copy link
Collaborator Author

ci:test:sf

@victorg1991 victorg1991 added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Nov 19, 2020
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1e59f5d5135630ff3ceeddaee94ba44f2c5b88d3

Sender Branch:

Branch Name: LPS-123673_asset_categories
Branch GIT ID: 494eee966737ddd9dbf3c2533abaf39f3cffe1cd

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#3473
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#2941
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - victorg1991 > liferay-echo - PR#2941 - 2020-11-18[23:39:34]
Spira Jenkins Build:publish-spira-report#14282

@ealonso
Copy link
Collaborator

ealonso commented Nov 19, 2020

Just started reviewing :)

:octocat: Sent from GH.

@ealonso
Copy link
Collaborator

ealonso commented Nov 19, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@ealonso ealonso added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. labels Nov 19, 2020
@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 25 jobs passed in 3 hours 32 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 1e59f5d5135630ff3ceeddaee94ba44f2c5b88d3

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 8d22a791300569a6c92e7b9152e6ae1c6bdc863a

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 25 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 1e59f5d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #418455

      Please fix semantic versioning on victorg1991/LPS-123673_asset_categories

           [exec] > Task :apps:asset:asset-publisher-web:copyLibs SKIPPED
     [exec] > Task :apps:asset:asset-publisher-web:classes
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] > Task :apps:asset:asset-categories-admin-web:jar
     [exec] > Task :apps:asset:asset-categories-admin-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:asset:asset-categories-admin-web:baseline SKIPPED
     [exec] > Task :apps:asset:asset-categories-admin-web:syncVersions
     [exec] 
     [exec] > Task :apps:asset:asset-publisher-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:asset:asset-publisher-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.37/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] 
     [exec] > Task :apps:asset:asset-publisher-web:compileJSP
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] Note: Some input files use unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:asset:asset-publisher-web:jar
     [exec] > Task :apps:asset:asset-publisher-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:asset:asset-publisher-web:baseline SKIPPED
     [exec] > Task :apps:asset:asset-publisher-web:syncVersions
     [exec] Gradle build finished at 2020-11-19 14:42:43.390.
     [exec] 598 actionable tasks: 585 executed, 13 up-to-date
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:asset:asset-categories-api:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.asset.categories.api-2.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.asset.categories.api/1.0.5/6577cf83c3da1b6e88cc40da24ddb5248e11873e/com.liferay.asset.categories.api-1.0.5.jar

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#96083

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#7451
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#2941
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - victorg1991 > liferay-echo - PR#2941 - 2020-11-19[03:39:00]
Spira Jenkins Build:publish-spira-report#7499

@victorg1991 victorg1991 deleted the LPS-123673_asset_categories branch December 18, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
3 participants
@victorg1991 @liferay-continuous-integration @ealonso