LPS-124657 Change the order to make sure we're not running into the race condition #3180

pavel-savinov · 2020-12-09T12:38:32Z

No description provided.

…et (we want to keep the PrincipalThreadLocal and ServiceContext throughout the calls)

…reate the first layout

…ace condition

liferay-continuous-integration · 2020-12-09T12:38:41Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

pavel-savinov · 2020-12-09T12:38:56Z

ci:forward

liferay-continuous-integration · 2020-12-09T12:39:01Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-12-09T12:43:23Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff774b85e421de0b8d1338adf7f2e2454c734303

Sender Branch:

Branch Name: pr-658
Branch GIT ID: 30b5862ae615d6be22dfc27e2f758e0b525ab1d2

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-12-09T12:52:24Z

Jenkins Build:test-portal-source-format#4808
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#3180
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - pavel-savinov > liferay-echo - PR#3180 - 2020-12-09[04:40:20]
Spira Jenkins Build:publish-spira-report#8480

liferay-continuous-integration · 2020-12-09T15:22:32Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 25 jobs passed in 2 hours 16 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ff774b85e421de0b8d1338adf7f2e2454c734303

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 22478fba589bf9dfa1ff6225fb25ee8fcbb03693

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 22 out of 25 jobs PASSED

3 Failed Jobs:

22 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ff774b8:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1
Job Results:
80 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #343637
  1. LocalFile.WidgetPagesUI#AddThenDeleteWidgetFromPage - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1131 Tests Passed.
4 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #323234

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
com.liferay.adaptive.media.exception.AMRuntimeException$IOException: Unable to scale file entry 44673 to match adaptive media configuration Preview-1000x0
com.liferay.adaptive.media.exception.AMRuntimeException$IOException: Unable to scale file entry 44673 to match adaptive media configuration Preview-1000x0
	at com.liferay.adaptive.media.image.internal.scaler.AMDefaultImageScaler.scaleImage(AMDefaultImageScaler.java:71)
	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:119)
	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:72)
	at com.liferay.adaptive.media.image.internal.processor.AMImageProcessorImpl.process(AMImageProcessorImpl.java:43)
	at com.liferay.adaptive.media.web.internal.messaging.AMProcessorCommand$2.execute(AMProcessorCommand.java:43)
	at com.liferay.adaptive.media.web.internal.messaging.AMMessageListener.doReceive(AMMessageListener.java:80)
	at com.liferay.portal.kernel.messaging.BaseMessageListener.doReceive(BaseMessageListener.java:48)
	at com.liferay.portal.kernel.messaging.BaseMessageListener.receive(BaseMessageListener.java:34)
	at com.liferay.portal.kernel.messaging.InvokerMessageListener.receive(InvokerMessageListener.java:74)
	at com.liferay.portal.kernel.test.rule.SynchronousDestinationTestRule$TestSynchronousDestination.send(SynchronousDestinationTestRule.java:394)
	at com.liferay.portal.m...

AXIS_VARIABLE=2,label_exp=!master #323234

LayoutSEOEntryLocalServiceTest.testAddLayoutSEOEntryWithCustomTags

java.lang.AssertionError: [com.liferay.dynamic.data.mapping.kernel.DDMFormFieldValue@b86f68be] expected:<2> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at com.liferay.layout.seo.service.test.LayoutSEOEntryLocalServiceTest.testAddLayoutSEOEntryWithCustomTags(LayoutSEOEntryLocalServiceTest.java:164)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at org.junit.rules.RunRules....

OpenGraphTopHeadDynamicIncludeTest.testIncludeCustomMetaTags

java.lang.AssertionError: expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at com.liferay.layout.seo.web.internal.servlet.taglib.test.OpenGraphTopHeadDynamicIncludeTest._assertMetaTag(OpenGraphTopHeadDynamicIncludeTest.java:1017)
	at com.liferay.layout.seo.web.internal.servlet.taglib.test.OpenGraphTopHeadDynamicIncludeTest.testIncludeCustomMetaTags(OpenGraphTopHeadDynamicIncludeTest.java:238)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.ev...

OpenGraphTopHeadDynamicIncludeTest.testIncludeIncompleteCustomMetaTags

java.lang.AssertionError: expected:<1> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
	at com.liferay.layout.seo.web.internal.servlet.taglib.test.OpenGraphTopHeadDynamicIncludeTest._assertMetaTag(OpenGraphTopHeadDynamicIncludeTest.java:1017)
	at com.liferay.layout.seo.web.internal.servlet.taglib.test.OpenGraphTopHeadDynamicIncludeTest.testIncludeIncompleteCustomMetaTags(OpenGraphTopHeadDynamicIncludeTest.java:387)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTes...

liferay-continuous-integration · 2020-12-09T15:23:14Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-12-09T15:23:29Z

Pull request has been successfully forwarded to brianchandotcom#96755

liferay-continuous-integration · 2020-12-09T15:32:09Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#5062
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#3180
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - pavel-savinov > liferay-echo - PR#3180 - 2020-12-09[05:04:35]
Spira Jenkins Build:publish-spira-report#12574

ruben-pulido · 2022-05-19T14:03:06Z

Just started reviewing :)

jkappler and others added 3 commits December 9, 2020 10:30

LPS-124657 Move try/catch to also cover update of layout and layout s…

bcad86c

…et (we want to keep the PrincipalThreadLocal and ServiceContext throughout the calls)

LPS-124657 Instead of using the default user, use the admin user to c…

fca663a

…reate the first layout

LPS-124657 Change the order to make sure we're not running into the r…

30b5862

…ace condition

pavel-savinov mentioned this pull request Dec 9, 2020

LPS-124657 Change the order to make sure we're not running into the race condition pavel-savinov/liferay-portal#658

Closed

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 9, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 9, 2020

liferay-continuous-integration mentioned this pull request Dec 9, 2020

LPS-124657 Change the order to make sure we're not running into the race condition brianchandotcom/liferay-portal#96755

Closed

liferay-continuous-integration closed this Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-124657 Change the order to make sure we're not running into the race condition #3180

LPS-124657 Change the order to make sure we're not running into the race condition #3180

pavel-savinov commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

pavel-savinov commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

ruben-pulido commented May 19, 2022

LPS-124657 Change the order to make sure we're not running into the race condition #3180

LPS-124657 Change the order to make sure we're not running into the race condition #3180

Conversation

pavel-savinov commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

pavel-savinov commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 23 out of 25 jobs passed in 2 hours 16 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/1

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

liferay-continuous-integration commented Dec 9, 2020

ruben-pulido commented May 19, 2022