Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-125128 prevent submitting form if default value is empty #3440

Closed
wants to merge 1 commit into from
Closed

LPS-125128 prevent submitting form if default value is empty #3440

wants to merge 1 commit into from

Conversation

marcosapmf
Copy link

@marcosapmf marcosapmf commented Jan 15, 2021 •
edited

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@marcosapmf
Copy link
Author

ci:test:sf

@marcosapmf
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9abb5412f865531a30c879edc61e94795e419bce

Sender Branch:

Branch Name: LPS-125128-4
Branch GIT ID: 2cb2276c1fa29726a2939c79bf1a29041bba9135

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#5092
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-echo#3440
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - marcosapmf > liferay-echo - PR#3440 - 2021-01-15[08:54:52]
Spira Jenkins Build:publish-spira-report#11932

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 28 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 9563dec9e9b8cff47d0863a94585ed6be2566657

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 2b89e6be0ae0f6e12dec390930d3e9525006e687

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 9abb541:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1797 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #449843
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to register portal instance {mvccVersion=1, companyId=20100, accountId=20103, webId=liferay.com, mx=liferay.com, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
com.liferay.portal.kernel.exception.PortalException: com.liferay.portal.kernel.exception.PortalException: com.liferay.portal.kernel.exception.InvalidRepositoryException: java.util.ConcurrentModificationException
	at com.liferay.layout.internal.instance.lifecycle.AddDefaultLayoutPortalInstanceLifecycleListener.addDefaultGuestPublicLayoutByProperties(AddDefaultLayoutPortalInstanceLifecycleListener.java:173)
	at com.liferay.layout.internal.instance.lifecycle.AddDefaultLayoutPortalInstanceLifecycleListener.portalInstanceRegistered(AddDefaultLayoutPortalInstanceLifecycleListener.java:75)
	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.registerCompany(PortalInstanceLifecycleListenerManagerImpl.java:142)
	at com.liferay.portal.instance.lifecycle.internal.PortalInstanceLifecycleListenerManagerImpl.addPortalInstanceLifecycleListener(PortalInstanceLifecycleListenerManagerImpl.java:90)
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invokeMethod(BaseMethod.java:228)
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.access$500(BaseMethod.java:41)
	at org.apache.felix.scr.impl.inject.methods.BaseMethod$Resolved.invoke(BaseMethod.java:664)
	at org.apache.felix.scr.impl.inject.methods.BaseMethod.invoke(BaseMethod.j...

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#8817
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-echo#3440
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - marcosapmf > liferay-echo - PR#3440 - 2021-01-15[08:54:58]
Spira Jenkins Build:publish-spira-report#14157

@victorg1991 victorg1991 added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jan 18, 2021
@victorg1991 victorg1991 self-assigned this Jan 18, 2021
@victorg1991
Copy link
Collaborator

Thanks LGTM 👏

@victorg1991
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@victorg1991 victorg1991 added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. labels Jan 18, 2021
@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#97803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@victorg1991 victorg1991

Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
3 participants
@marcosapmf @liferay-continuous-integration @victorg1991