Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS] LPS-129394 | On Portal Startup, the portal tries to create an already existing default vocabulary. #4070

Closed
wants to merge 23 commits into from
Closed

[TS] LPS-129394 | On Portal Startup, the portal tries to create an already existing default vocabulary. #4070

wants to merge 23 commits into from

Conversation

bakayattila
Copy link
Collaborator

@bakayattila bakayattila commented Mar 18, 2021 •
edited

Hi Team,
Could you please review this pull request?
https://issues.liferay.com/browse/LPS-129394

Thank you!

liuxingye and others added 23 commits March 18, 2021 09:26
@liuxingye @brianchandotcom
LPS-122831 Add path for view response body in my activity
4c47402
@liuxingye @brianchandotcom
LPS-122831 Add macros for edit question and view my activity default
9368538
@liuxingye @brianchandotcom
LPS-122831 Add tests for show responses in my activity
08a5ef3
@liuxingye @brianchandotcom
LPS-129274 Update macro for mention via comment as a guest
dac281a
@liuxingye @brianchandotcom
LPS-129274 Add test for view mention as a guest
044617c
@Jeremy-Ch @brianchandotcom
LPS-128708 Add test for the friendly URL
6a897b3
@Hanlf @brianchandotcom
LPS-129276 Add test about disabling xuggler
e5973b3
@Hanlf @brianchandotcom
LPS-129276 Update macro to disable xuggler
d54393e
@austinchiang @brianchandotcom
LPS-129276 Wordsmith
fc287f3
@brianchandotcom
LRQA-65807 Add sybase batches to publications environments suite
1892733
@vicnate5 @brianchandotcom
LRQA-65922 Create liferay online test suite
430b579
@vicnate5 @brianchandotcom
LRQA-65922 Include limit properties file
10f25ba
@kresimir-coko @brianchandotcom
LPS-128658 Fix misalignment of icons in the portlet-topper-toolbar
56968aa
@brianchandotcom
LPS-129064 Modify macro to assert Hello World for upgrade cases
52cda4c
@brianchandotcom
LPS-129064 Remove deprecated locator
d73d2ea
@brianchandotcom
LPS-129064 Modify macro to view welcome content page
d998145
@brianchandotcom
LPS-129064 Replace macro
d3709f8
@dacousalr @brianchandotcom
LPS-129244 Print the stack trace only at DEBUG level
ce38183
@dantewang @brianchandotcom
LPS-120742 Remove Jetty related classes as they are deprecated as of …
6f8897e 
…7.2.x
@dantewang @brianchandotcom
LPS-120742 packageinfo
73405a1
@dantewang @brianchandotcom
LPS-120742 Remove Jetty Server dependencies from core
809dc4a
@tinatian @brianchandotcom
LPS-120742 Remove as jetty jars has been removed
67633d9
@bakayattila
LPS-129394 Using the _getVocabularyName from AssetVocabularyLocalServ…
85270d3 
…iceImpl to search by name in the same format.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@bakayattila
Copy link
Collaborator Author

ci:test:sf

@bakayattila
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ac8267406785c2e70f4b15aadd604fbe7fb4451b

Sender Branch:

Branch Name: LPS-129394
Branch GIT ID: 85270d3f17879e444c49f28c5172fa3e078048f6

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 22 jobs passed in 1 hour 26 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1087401_7068

Base Branch:

Branch Name: master
Branch GIT ID: ac8267406785c2e70f4b15aadd604fbe7fb4451b

Upstream Comparison:

Branch GIT ID: dfa20979364a89ce186db49c66bd1807426d3d67
Jenkins Build URL: Acceptance Upstream DXP (master) #1650

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 22 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #4684
           [exec] | | | | | | | | | | | | |____0
     [exec] | | | | | | | | | | | | | |____0
     [exec] | | | | | | | | | | | | | | |____jenkins-console.txt.gz
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210318101526568
     [echo] send.to.testray.logs.start.timestamp: 03-18-2021 10:15:26:584 PDT
     [echo] Sending Testray logs to Testray production server.
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210318101526587
[stopwatch] [send.to.testray.logs: 0.238 sec]
     [echo] send.to.testray.results.start.timestamp: 03-18-2021 10:15:26:822 PDT
     [echo] Sending Testray results to Testray production server.
   [delete] Deleting: /opt/dev/projects/github/liferay-jenkins-ee/commands/20210318101526825
[stopwatch] [send.to.testray.results: 0.156 sec]
[stopwatch] [record.testray.results.TESTS-test-1-8_test-portal-acceptance-pullrequest(master)_7068_semantic-versioning-jdk8/0_0_functional.xml: 0.715 sec]
[stopwatch] [record.testray.results: 0.958 sec]
[stopwatch] [run.current.job: 19.847 sec]
[beanshell] Created cache file in /tmp/jenkins-cached-files/-983460268.txt

      BUILD FAILED
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:12870: The following error occurred while executing this line:
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common-portal-acceptance-batch.xml:264: The following error occurred while executing this line:
      
/opt/dev/projects/github/liferay-jenkins-ee/commands/build-common.xml:9842: Sourced file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : Typed variable declaration : Method Invocation GitHubDevSyncUtil.fetchCacheBranchFromGitHubDev : at Line: 47 : in file: inline evaluation of: 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : GitHubDevSyncUtil .fetchCacheBranchFromGitHubDev ( gitWorkingDirectory , remoteCacheBranchName )
      

      Called from method: fetchCacheBranchToLocalBranch : at Line: 34 : in file: inline evaluation of: `` 								 									import com.liferay.jenkins.results.parser.GitHubDevSyncUtil;  . . . '' : fetchCacheBranchToLocalBranch ( sb .toString ( ) , gitWorkingDirectory .getUpstreamBranchName ( ) )
      
Target exception: java.lang.RuntimeException: Unable to fetch cache-liferay-ac8267406785c2e70f4b15aadd604fbe7fb4451b-liferay-ac8267406785c2e70f4b15aadd604fbe7fb4451b from git@github-dev.com

For upstream results, click here.

@sandrodw3 sandrodw3 added the 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. label Mar 19, 2021
@jkappler jkappler self-assigned this Mar 22, 2021
@jkappler
Copy link

Just started reviewing :)

@jkappler
Copy link

#4084

@jkappler jkappler closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jkappler jkappler

Labels
🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. ci:test:relevant - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone