Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-129552 Can not link to a public page when adding a link in Rich Text #4116

Closed
wants to merge 2 commits into from
Closed

LPS-129552 Can not link to a public page when adding a link in Rich Text #4116

wants to merge 2 commits into from

Conversation

ambrinchaudhary
Copy link

@ambrinchaudhary ambrinchaudhary commented Mar 25, 2021 •
edited

This is a fix for https://issues.liferay.com/browse/LPS-129552.

Steps to reproduce:

  1. Go to Product Menu > Web Content > Create a new Web Content
  2. On the editor, try to add a link(Click Browse Server > Go to Public Pages tab > Select one page)

Screenshot 2021-03-25 at 13 52 06

Expected result:
Can select a page to link.
Actual Result
Can not select a page to link: Clicking the page can not select it and no save button shows on the Select Item page

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ambrinchaudhary ambrinchaudhary changed the title LPS-129552 Do not escape eventName, otherwise it is different from the modal opener and does not work LPS-129552 Can not link to a public page when adding a link in Rich Text Mar 25, 2021
@ambrinchaudhary
Copy link
Author

ci:test:sf

@ambrinchaudhary
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Sender Branch:

Branch Name: LPS-129552_Journal_CKEDitor_link
Branch GIT ID: 84169d9c3adcdb4f1d5d1e2b8dbaa58d20c94a0c

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/layout/layout-item-selector-web/src/main/resources/META-INF/resources/init.jsp expected:<...ewDisplayContext" %>[]
     [java] 
     [java] <liferay-frontend:...> but was:<...ewDisplayContext" %>[<%@
     [java] page import="com.liferay.portal.kernel.util.HtmlUtil" %>]
     [java] 
     [java] <liferay-frontend:...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:452)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:297)
[stopwatch] [run.batch.test.action: 1:17.096 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:706: Java returned: 1
      [get] Getting: http://test-1-4/job/test-portal-source-format/4498//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210325055841069.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210325055841069.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1221557886.properties

merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null918333343

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 185ms

[junitreport] Deleting: /tmp/null918333343

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 03-25-2021 05:58:46:171 PDT

[stopwatch] [run.batch.test.tear.down: 0.000 sec]

[echo]

[echo] Ant GC log:

[echo]

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 25 jobs passed in 2 hours 10 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Upstream Comparison:

Branch GIT ID: 20206ada64511caf36d53e6bf5781dfe948f2f30
Jenkins Build URL: Acceptance Upstream DXP (master) #1675

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 25 out of 25 jobs PASSED
25 Successful Jobs:
For more details click here.

@sandrodw3 sandrodw3 added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Mar 25, 2021
@victorg1991 victorg1991 self-assigned this Mar 25, 2021
@ambrinchaudhary
Copy link
Author

ci:test:sf

@ambrinchaudhary
Copy link
Author

Sorry for the SF error, just fixed!

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Sender Branch:

Branch Name: LPS-129552_Journal_CKEDitor_link
Branch GIT ID: 9b834d76a26bd391851e7609597fe8dd7dc7e0f9

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@victorg1991
Copy link
Collaborator

Thanks!!

@victorg1991
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@victorg1991 victorg1991 added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. labels Mar 25, 2021
@victorg1991 victorg1991 removed their assignment Mar 25, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 25 out of 25 jobs passed in 1 hour 53 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c

Upstream Comparison:

Branch GIT ID: 02c62c690a8056ad107ac4f79b69cadca07d027c
Jenkins Build URL: Acceptance Upstream DXP (master) #1676

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 25 out of 25 jobs PASSED
25 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#100307
Console

@ambrinchaudhary ambrinchaudhary deleted the LPS-129552_Journal_CKEDitor_link branch April 8, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
4 participants
@ambrinchaudhary @liferay-continuous-integration @victorg1991 @sandrodw3